SetScores does not seem to be returning null when it should be. According to the documentation on the feature, the Return values are the key value of the updated user if sccessful, null otherwise.
Instead, if there is no hub/hub_password set, SetScores is returning "" rather than null. As such, the documentation's recommendation of "Use isnull() to check for a null value." is invalid.
Code Snippet (if applicable) to Reproduce Problem:
mob/verb/test()
var/list/l = list("test"=112233)
if(isnull(world.SetScores("Ter13",params2list(l))))
world << "This should be called, as the hub is not being contacted."
Expected Results:
Should return null, or the documentation should reflect the actual return value.
Actual Results:
Returns a zero-length string, which is very much not null.
Workarounds:
Obviously, doing this without a hub/hub_password set is not desired, but of course, the documentation never cautions the user to set up a hub/hub_password in the first place. It's obvious to those who understand how it works, but obviously, this is BYOND, and assuming understanding of systems should probably be avoided.
Please either update the reference to note that hub/hub_password is needed, as well as change it to reflect that a zero-length string is returned, or change the return value to properly be null in this case.
Thank you.