All I can say, with my jaw hanging limp like this, is your code is royally screwy. It's so far from anything logical it's mind-boggling--but it'd work if DM worked a completely different way.

Here are the suspect lines of code:

proc
CheckOpen(door)
if (src.icon_state == "closed")
door = 0
else
door = 1
..(door)

verb
open()
set src in view(1)
var/door
CheckOpen(door)
if (!door)

The reason I'm aghast is that this is just so totally wrong; sending a scalar variable like a number to a proc, having the proc modify it, and expecting the modification to be carried back into the caller is something that works with only references and pointers--the sorts of concepts found in C++ and Visual Basic. In most languages, however, including DM, the value you pass is a copy, and the only time changes can carry back is if you're sending an object or a list whose contents are changed.

Now, in CheckOpen, you're modifying "door" as if it's supposed to do something; but it doesn't, because you're modifying a copy of the variable, and the copy only belongs to the current proc. The call to ..(door) is useless, because there's no CheckOpen proc for a regular obj.

Because the whole pointer/reference thing is completely inane, these three lines won't work:

var/door
CheckOpen(door)
if (!door)

Since you're not assigning anything to var/door, it assumes it's null, or 0. CheckOpen(door) does nothing, because a copy of door is sent to the proc, which modifies the copy and then tries to call a nonexistent obj/proc/CheckOpen(door). So if(!door) will always be true. Likewise, if(door) in the following proc is always false.

I guess the assumption of reference passing makes sense if you come from a Visual Basic background, but the way you rely on it like that is really bizarre; I think even most people who aren't aware that a copy is being passed would still think in a function mentality, of using CheckOpen to return a value and using that returned value in the if() statement. It looks to me like the reference thing is a very bad habit you must have picked up somewhere.

To fix your code, you need to change the procs as follows:

Or, more simply:

To fix the verb:

That ought to get you back on track.

Lummox JR

verb
open()
set src in view(1)
if (!CheckOpen(door)) //Line 85

After looking up "arguments" and getting shifted to "named arguments" I realized that the arg "door" was amazingly useless, just like this post.

Tired and going to be very soon.

Here is a rather easy door code that I use, I hope it helps you out a little.

obj
     Door
          icon = 'Door.dmi'
          icon_state = "Closed"
          density = 1
          verb
               Close_Door()
                    set src in view(1)
                    if(src.icon_state == "Open")
                         src.icon_state = "Closed"
                         src.density = 1
                    else
                         usr << "This door is closed, duh!"
               Open_Door()
                    set src in view(1)
                    if(src.icon_state == "Closed")
                         src.icon_state = "Open"
                         src.density = 0
                    else
                         usr << "This door is already open!"

Happy Thanksgiving!!

Hehe, that'll perfect!

You can compress it to one verb if you wanted!

Should work. :p