? Old Q (didn't get a full answer...) ?

ID:179658
 
Nov 23 2001, 6:44 pm
I'm working on the inventory and equipment issue right now.
I need a click proc where it equips or unequip something when you click on it on the inventory panel.
Here's what i have :

obj/weapons
var
attack
basetype

Click()
set src in usr
if(usr.rhand == "")
usr.rhand = src
usr.rhandtype = src.basetype
usr.attack += src.attack
else
alert("Something is equip!","Oops")
return 0

if(usr.rhand == src)
usr.rhand = ""
usr.rhandtype = ""
usr.attack -= src.attack
else
alert("Don't have it equip!","Oops")
return 0

As you can see, it probably the buggiest thing you have ever seen.
Some bugs:
-I can equip a weapon when it's still on the ground.
(When it isn't in my inventory panel)

-I can equip more than 1 weapons; it shows the icon of one of them on the panel, but my power keeps getting up.

Any suggestions,ideas ?
THX.
Nov 23 2001, 6:58 pm
I can see a few problems with your code:

  • "set src in usr" doesn't work for Click(); you need to add an if() statement to check if the clicked object is in the user's inventory.
  • The "return 0" statement is executed before the code checks whether to unequip anything. The first "else" before that should probably be moved to the end, so you have: if(usr.rhand==""), then else if(usr.rhand==src), then else. This doesn't explain the problem you're having, but it should fix others.
  • The past tense of "equip" is "equipped", and your alert procs (one of which isn't necessary, once you rearrange the if statements) don't have the -ed. What is it with anime fans and leaving off the -ed, anyway?

    Lummox JR
Nov 23 2001, 7:11 pm (Edited on Nov 23 2001, 7:40 pm)
In response to Lummox JR
lol. I had to remove some words from the alert proc so it would be easier to read the code (removed the -ed at the same time).
I'm not an anime fan, so i didn't know what you were talking about there.

Thx for your help. It works now.

Also, can you give me an example of a weapon restriction
code for each class ?
Someone told me to go with istype(), but i learn better with an example.
Nov 23 2001, 9:03 pm
In response to Cravens
istype() would be one way to go

example

mob
wizard
mob
warrior
obj
sword
verb
equip()
if(istype(usr,/mob/warrior))
usr << "You equip da sword foo!"
else
usr << "You arent a warrior get outta here!"
Nov 23 2001, 9:17 pm
In response to FIREking
hmm.. Thx, but there's a few prob with my code.
First, i don't have an Equip verb.
I have a click proc that equips.
Here's my code:

obj/weapons
var
attack
basetype

Click()
if(src in usr)
if(usr.rhand == "")
usr.rhand = src
usr.rhandtype = src.basetype
usr.attack += src.attack
usr<<"[src.name] has been equipped."
else
if(usr.rhand == src)
usr.rhand = ""
usr.rhandtype = ""
usr.attack -= src.attack
usr<<"[src.name] unequipped"
else
alert("Something is Equip!","Sorry")
return 0

obj/weapons
Knife
basetype = "weapons"
attack = 3
price = 20
icon = 'weapons.dmi'
icon_state = "knife"


Now,as you can see, ALL the weapons are in one
single um... obj/ thingy... (sorry, forgot the word).
I don't have a obj/sword, obj/bow, obj/hammer.
So if i do it your way, there's only going to be one class that can equip weapons.
Any suggestions?
THX.
(Sorry about my post. It's 3am here and i'm watching
"True Lies")
Nov 23 2001, 9:20 pm
In response to Cravens
it doesnt matter if you have an equip verb, i showed you an example. Look at the example, and figure out how you will use something similair in your game.
Nov 24 2001, 5:44 am
In response to Cravens
What you probably want to do is to make all your weapons of a class /obj/weapon or /obj/item/weapon, then for /obj/weapon define a proc, CanEquip(), to check to see if the weapon can be equipped or not.
obj/item/weapon
  proc/CanEquip(mob/M)
    return 1     // sure, anybody can use this

  sword
    CanEquip(mob/M)
      return (istype(M,/mob/warrior) || istype(M,/mob/knight))

Now to use this, you'll have to include a call to src.CanEquip(usr). (The src. part is redundant, but I just put it in to show that this proc belongs to the weapon.) A line like this would work:
    ...
    if(!CanEquip(usr))
      usr << "You can't equip \a [src]."
      return
    ....

Lummox JR
Nov 24 2001, 7:04 am
In response to Lummox JR
Wow, it works !
Since i have a lot of mobs, it will take some time to
put them all.

If i have a lot of different colors for each kind of class,
is it possible to put their stats in a single mob ?
Here's what i mean :
mob
bluewizard
icon = 'wizard.dmi'
icon_state = "blue"
hp = 20
attack = 1

redwizard
icon = 'wizard.dmi'
icon_state = "red"
hp = 20
attack = 1

blueknight
icon = 'knight.dmi'
icon_state = "blue"
hp = 40
attack = 2

redknight
icon = 'knight.dmi'
icon_state = "red"
hp = 40
attack = 2

Would something like this give me the same result ?

mob
wizard
bluewizard
icon = 'wizard.dmi'
icon_state = "blue"
redwizard
icon = 'wizard.dmi'
icon_state = "red"

hp = 20
attack = 1

I want to put each class in one single mob block.






Nov 24 2001, 7:08 am
In response to Cravens
Cravens wrote:
Wow, it works !
Since i have a lot of mobs, it will take some time to
put them all.

If i have a lot of different colors for each kind of class,
is it possible to put their stats in a single mob ?
Here's what i mean :
mob
bluewizard
icon = 'wizard.dmi'
icon_state = "blue"
hp = 20
attack = 1

redwizard
icon = 'wizard.dmi'
icon_state = "red"
hp = 20
attack = 1

blueknight
icon = 'knight.dmi'
icon_state = "blue"
hp = 40
attack = 2

redknight
icon = 'knight.dmi'
icon_state = "red"
hp = 40
attack = 2

Would something like this give me the same result ?

mob
wizard
bluewizard
icon = 'wizard.dmi'
icon_state = "blue"
redwizard
icon = 'wizard.dmi'
icon_state = "red"

hp = 20
attack = 1

I want to put each class in one single mob block.

no, but
mob
wizard
bluewizard
icon = 'wizard.dmi'
icon_state = "blue"

redwizard
icon = 'wizard.dmi'
icon_state = "red"
hp = 20
attack = 1


would its called inheritence.
Nov 24 2001, 10:55 am
In response to Cravens
Would something like this give me the same result ?

mob
wizard
bluewizard
icon = 'wizard.dmi'
icon_state = "blue"
redwizard
icon = 'wizard.dmi'
icon_state = "red"

hp = 20
attack = 1

That's close to what you'd want, but I'd do it like this:
mob 
  wizard
    icon = 'wizard.dmi'
    hp = 20
    attack = 1

    blue
      icon_state = "blue" 
    red
      icon_state = "red"

You'd want to put as much in the main wizard block as you could, and just use the subclasses like red and blue to change as little as possible.

Lummox JR