view() that ignores lighting

Page: 1 2
ID:1863682
 
Jun 1 2015, 2:00 pm (Edited on Jun 1 2015, 2:05 pm)
Redundant
Applies to:DM Language
Status: Redundant
This feature has already been implemented, or is already achievable with existing methods.
Basically, add a variant of view(), which ignores luminosity.
Jun 1 2015, 2:11 pm
I think hearers() might do this already.
Jun 1 2015, 2:14 pm
Oh, it might, nevermind then
Jun 1 2015, 2:18 pm (Edited on Jun 2 2015, 7:23 am)
Actually, hearers says in the DM reference that it's mobs only, not atoms, so it wouldn't do the trick fully
Jun 1 2015, 2:19 pm (Edited on Jun 1 2015, 2:25 pm)
 
var
    mob/__riddick = new/mob{density=0,invisibility=101}()
proc
    shine_view(Dist=5,atom/movable/Center)
        if(!Center) Center = usr //this is correct. Do not question me.
        __riddick.loc = Center.loc
        if(istype(Center))
            __riddick.step_x = Center.step_x
            __riddick.step_y = Center.Step_y
        __riddick.see_in_dark = Dist
        . = view(Dist,__riddick)
        __riddick.loc = null
Jun 1 2015, 2:21 pm
Well, yeah, that works, but it's still something that's just nice to have built in
Jun 1 2015, 2:22 pm
Well, yeah, that works, but it's still something that's just nice to have built in



FFS.
Jun 1 2015, 3:52 pm
Nadrew resolved issue (Redundant)
Jun 1 2015, 4:01 pm
I don't really see why this is redudant, whilst hearers (which is just a version that's locked to mobs for some dumb reason) is a thing.
Jun 1 2015, 4:06 pm
which is just a version that's locked to mobs for some dumb reason

hearers() was added because it's useful for speeding up AI target seeking behaviors. It's something that's done ALL THE TIME. It makes perfect sense why it was added.

As for why this bit's redundant, is that I managed to produce the feature in 12 lines of code, and there will be next to no speed improvement of transitioning it to C++. This is because the brunt of the CPU overhead of my approach is actually being done by a built-in function. The softcode itself barely does anything. Further, my implementation allows you to use it as though it were built in, minus the stupid names.

Now, I could understand additional parameters for view() that allow you to override see_in_dark, see_infrared, see_invisible, etc, thus affecting the return value, but adding a whole new filtering variant for something that view technically does already provided you use it properly?

Dunno, seems pretty redundant if you ask me.
Jun 1 2015, 5:35 pm
I don't see why you can't just make something like hearers() not restricted to mobs, just use a for() loop to filter out mobs.
Jun 1 2015, 5:49 pm
PJB3005 wrote:
just use a for() loop to filter out mobs.

PJB3005 wrote:
Well, yeah, that works, but it's still something that's just nice to have built in

I'll just let the two of you hash this out.
Jun 2 2015, 7:22 am
I don't see how those 2 quotes relate to eachother...
Jun 2 2015, 1:26 pm
The function can be built yourself, you can even just use your own suggestion and do it that way. It's unneeded.
Jun 2 2015, 1:28 pm
What I'm getting at is, why is there no proc like this, whilst hearers() is a thing, hearers is OBJECTIVELY less useful than this.
Jun 2 2015, 1:41 pm
hearers is OBJECTIVELY less useful than this.

Considering almost every BYOND game that uses any kind of AI system uses hearers(), while this is the first time that someone has requested this feature... I'm not actually sure that's true.

What I will say is this: BYOND's built-in lighting approach should have been deprecated years ago. It's ugly and nobody outside of BYOND will willingly subject themselves to it for more than a few minutes without complaint. Making any kind of serious project using that lighting system is a waste of time.
Jun 2 2015, 1:43 pm
for(var/mob/M in betterhearers(range))
Jun 2 2015, 1:44 pm
Because there doesn't need to be a proc like this, it's trivial to do on your own and it being built-in wouldn't dramatically decrease overhead.
Jun 2 2015, 1:46 pm
Such can be said for a lot of procs like max(), min(), and others.
Jun 2 2015, 1:47 pm
Such can be said for a lot of procs like max(), min(), and others.

Name a single programming language that doesn't have those functions. You are just being silly now.
Page: 1 2