ID:1916956
 
Resolved
The on-show command for maps didn't work.
BYOND Version:508.1295
Operating System:Windows 7 Ultimate 64-bit
Web Browser:Chrome 45.0.2454.37
Applies to:Webclient
Status: Resolved (508.1296)

This issue has been resolved.
Descriptive Problem Summary:
Map control isn't showing for /tg/station13 on the webclient.

I had a few other people test, they reported the same thing.

Same code, two different versions:

http://i.imgur.com/hnIwwSD.png - 1295
http://i.imgur.com/H5IxSdR.png - 1294

The broken version is currently live at http://www.byond.com/play/174.21.19.100:31337

Time frozen code link: https://github.com/tgstation/-tg-station/archive/ 66daea538e18226edb587fe9b427006a7926578f.zip

Does the problem occur:
Every time? Or how often?
Every time
In other games?
In other user accounts?
On other computers?
Not tested

When does the problem NOT occur?
See below
Did the problem NOT occur in any earlier versions? If so, what was the last version that worked? (Visit http://www.byond.com/download/build to download old versions for testing.)
Only in 508.1295. Map control shows up in 1294
Workarounds:
None known
Thanks. I'll download and compile the code and try to reproduce this on my end. I'm sure it's fixable.
Oh, one thing, I forgot. code/modules/client/client procs.dm has client's New(). and it normally rejects clients not seeker (line 95-96), I commented it out for my test case (as I figured I'd checkup on the progress of ds'ifing on the webclient)
Thanks for the heads-up.
Lummox JR resolved issue with message:
The on-show command for maps didn't work.
Descriptive Problem Summary:
I simply updated from 508.1294 to 508.1295, re-ran Dream Daemon, started the game, and tested with webclient.

Numbered Steps to Reproduce Problem:
1. Test in Dream Seeker (Working)
2. Test in FireFox 39 and Chrome 44 on primary game system, blocking extensions disabled (Fail)
3. Test in FireFox 40 and Chrome 44 on server system, no blocking extensions installed (Fail)

Code Snippet (if applicable) to Reproduce Problem:


Expected Results:

Actual Results:

Does the problem occur:
Every time? Or how often? Every time.
In other games? Unknown.
In other user accounts? Yes (I have three accounts made for testing.)
On other computers? Yes

When does the problem NOT occur?

It has yet to not occur.

Did the problem NOT occur in any earlier versions? If so, what was the last version that worked? (Visit http://www.byond.com/download/build to download old versions for testing.)

Yes, it worked fine in 508.1294.

Workarounds:

None currently known.
In response to Khyberkitsune
Webclient reports belong in Beta Bugs. Please check out id:1916956 to compare, because I'm fairly certain this is the exact same bug that was already reported and closed.
In response to Khyberkitsune
Double-checking that entry, mine doesn't happen in .1294 and .1295 like theirs does, only .1295 for my end.

In response to Khyberkitsune
That report specifically said 1294 works, and 1295 does not. Do you have a skin whose map has an on-show parameter?
In response to Khyberkitsune
I have no skins at all. This is the bare UI.

And this isn't even the same problem, checking from their screenshots.

My minimap still doesn't show properly, but that's a known issue with the webclient according to your last response to me in another thread. My problem has nothing to do with that.

I'm talking about the entire world view fails to render. You no longer get x/y/z coordinates listed because you failed to render and are not even on the map. You cannot move. You cannot see the players around you, players cannot see you. You cannot even chat. Others see you login or logout, but that is it. You can do nothing except roll dice and play with the random food generator.

http://i.imgur.com/ElyfBUu.png - Webclient .1295 on left, DS .1295 on the right. The webclient guest should have spawned on the lower-left corner of the leopard print section. As you can see, they're not there.

Nothing changed except moving from 508.1294 to 508.1295. I hadn't even changed a single line of code in my project.

In response to Khyberkitsune
So I just hit up their server to look. In theirs you can still do things like chat (I'm noticing their external window seems to suffer similar problems as mine, yet theirs is still somewhat functional.) You can't do any of that in mine.

I'll just revert back to 508.1204 for now. That seems to be the only fix. The code I'm using is quite often verbatim from the guide/documentation or other libraries.
In response to Khyberkitsune
I'll need a test case to see what's going on. If you can get me a link to your source, I'll download it and try to reproduce this on my end. The fact that you can't even chat would indeed suggest this is a different issue and more serious, so I'd like to fix it as soon as I can.

The sooner today you can get that to me, the more likely I can have it fixed for 508.1296.
In response to Khyberkitsune
http://www.filehosting.org/file/details/503588/AE1.0034.7z

There you go! Run it on a .1295 server and try the web client. You should also notice some very odd and serious lag trying to type anything into external input boxes (like when you click the say command in the Communication tab in the upper right tab group.)
In response to Khyberkitsune
That file host doesn't allow direct downloads without sending a link to my email, and I'm not getting any such message. Please try a different host.
In response to Khyberkitsune
http://s000.tinyupload.com/ index.php?file_id=00342774627598076721

Hopefully that works!

EDIT: It works but do have an adblocker. Damned site tries to pop iLivid adware/hijacker on your system.
In response to Khyberkitsune
Uh, I'm not gonna trust an upload site that has malware even with an adblocker. Maybe try something else. Some users have had good luck with sendspace.
In response to Khyberkitsune
Yea, I wouldn't trust it too far, either. Only tries when you left-click. Right-clicking works. In any case, here's a new download link:

https://www.sendspace.com/file/0xsyaw
In response to Khyberkitsune
Hrm.. upon further testing, I isolated the chat problem. Because of where the ghost mob spawned on the map, it was out of sight for the other players (in-view but behind an object that was dense and opaque,) and thus spoken words would not be received anyways.

Still wondering about the heavy input lag which I'm still getting when I click and attempt to utilize the 'say' command in the webclient in the latest beta... It doesn't happen in 508.1294.
In response to Khyberkitsune
This is as I thought. If your chat problem is unrelated, and the say() thing is its own issue at best, this boils down to the map control using on-show. This is in fact a duplicate of the other issue.
If your testing with my own code reflects that, sorry to have wasted your time!