Interface Not-Popping up

ID:1923236
 
Aug 23 2015, 1:59 am
(See the best response by Kaiochao.)
Code:
    Admin_1
        verb
            View_Player_Logs()
                set category="Admin"
                var/list/List_One=list()
                List_One.Add("Cancel")
                for(var/mob/A in world) if(A.Player) List_One.Add(A)
                var/mob/M = input(usr,"Whose logs do you want view?") in List_One
                if(M == "Cancel") return
                winset(src,"RC","visible"=="true")
                winshow(src,"RC",1)
                winset(src, "RC.Name", "text"=="Log Check: [M.name]")
                winset(src, "RC.1", "text"=="Log Check: [M.Written_Roleplay]")
                winset(src, "RC.2", "text"=="Log Check: [M.Roleplay_Characters]")
                winset(src, "RC.Log1","text"=="[M.PlayerLog]")


Problem description:
Although, I'm quite sure that I got the programming right; it won't pop up which is annoying because, I've turned visible and default off in the interface; but, it still won't show itself.
Aug 23 2015, 2:05 am
Your winset calls are all kinds of wrong. They can also be stacked up into a single call:

winset(src,null,"RC.Name.text=\"Log Check: [M.name]\";RC.1=\"Log Check: [M.Written_Roleplay]\";RC.2.text=\"Log Check: [M.Roleplay_Characters]\";RC.Log1.text=\"[M.PlayerLog]\";RC.is-visible=true;")
Aug 23 2015, 2:12 am
Best response
That's not the correct syntax for winset parameters.
                winset(src, "RC", "is-visible=true")
                winshow(src,"RC",1) // this is the same as the line above
                winset(src, "RC.Name", "text=[url_encode("Log Check: [M.name]")]")
                winset(src, "RC.1", "text=[url_encode("Log Check: [M.Written_Roleplay]")]")
                winset(src, "RC.2", "text=[url_encode("Log Check: [M.Roleplay_Characters]")]")
                winset(src, "RC.Log1","text=[url_encode(M.PlayerLog)]")

You should also be able to stuff these settings into one winset():
winset(src, null, list2params(list(
    "RC.is-visible" = "true",
    "RC.Name.text"  = "Log Check: [M.name]",
    "RC.1.text"     = "Log Check: [M.Written_Roleplay]",
    "RC.2.text"     = "Log Check: [M.Roleplay_Characters]",
    "RC.Log1.text"  = M.PlayerLog
)))
Aug 23 2015, 2:13 am
In response to Ter13
I'm pretty sure it's safer to use url_encode() or list2params() (which uses URL encoding) in winset() calls so that embedded text containing quotes won't break the query.
Aug 23 2015, 2:50 am
In response to Kaiochao

I was able to get something like this using the programming below
View_Player_Logs()
                set category="Admin"
                var/list/List_One=list()
                List_One.Add("Cancel")
                for(var/mob/A in world) if(A.Player) List_One.Add(A)
                var/mob/M = input(usr,"Whose logs do you want view?") in List_One
                if(M == "Cancel") return
                winset(src,"RC","visible"=="true")
                winshow(src,"RC",1)
                src<<output("Log Check: [M.name]","Name")
                src<<output("[M.Written_Roleplay]","1")
                src<<output("[M.Roleplay_Characters]","2")
                src<<output("[M.PlayerLog]","Log1")


Problem:
It doesn't show the HTML, I would like it to show ( is it because, I didn't end it with the /body and /html; its suppose to have. Also, could someone tell me or explain to me url_encode() and list2params(). Don't really understand what it meant in the DM Help.
Aug 23 2015, 3:12 am
Label controls don't support HTML. I'm guessing this is what you're using.
Output controls support limited HTML.
Browser controls support full HTML.

The purpose of url_encode() is to apply URL encoding to text.

The list2params() proc converts a list into params format. The keys and values of the provided list are URL-encoded for the returned parameter string. There are examples of params format in its Reference entry. I'm not sure how to explain it further.

You should just remove that winset(src,"RC","visible"=="true") line. It's redundant and also wrong, as shown in previous posts.
Aug 23 2015, 3:35 am
In response to Kaiochao
Thanks a lot for the information; within the Interface, there seems to be a problem with actually changing the colour of the Browser control from White to Black. -- Sorry. Any ideas how to do it.
Aug 23 2015, 3:40 am
In response to AngelReincarnation
If the browser control doesn't have a background-color parameter, then you probably have to use CSS: (this would go in the HTML you send to the browser)
<style>
body {
    background-color: black;
}
</style>