Web client doesn't load

BYOND Forums

Announcements · BYOND Help · Bug Reports · Feature Requests · Beta Testers · Beta Bugs · Developer Help · Design Philosophy · Demos & Libraries · Tutorials & Snippets · Art & Sound · Classified Ads · Game Updates · Contests & Events · Linux Talk · On Topic · Off Topic

ID:1957241

Oct 8 2015, 6:13 pm

MrStonedOne

Resolved

The new info control color options didn't work in some browsers and could cause problems at load time.

BYOND Version:	509.1304
Operating System:	Windows 7 Ultimate 64-bit
Web Browser:	Chrome 46.0.2490.52
Applies to:	Webclient

Status:

Resolved (509.1305)

This issue has been resolved.

Descriptive Problem Summary:
Attempting to connect to the webclient on /tg/station13 code locks up while downloading resources at the final bit.

Console reports this error:

Uncaught Uncaught Error: Invalid argument(s): property is not a String or num
Stack Trace:
Invalid argument(s): property is not a String or num
at dart.wrapException (http://localhost:31337/res/webclient.dart.js:20298:15)
at JsObject.dart.JsObject.$index (http://localhost:31337/res/webclient.dart.js:28968:17)
at ByondJS_controlCssAttr_closure1.dart.ByondJS_controlCssAttr_ closure1.call$1 (http://localhost:31337/res/webclient.dart.js:12913:18)
at LinkedHashMapKeyIterable.dart.LinkedHashMapKeyIterable.forEa ch$1 (http://localhost:31337/res/webclient.dart.js:21837:11)
at dart.ByondJS_controlCssAttr (http://localhost:31337/res/webclient.dart.js:1557:113)
at ByondJS_classMethods_closure38.dart.ByondJS_classMethods_clo sure38.call$2 (http://localhost:31337/res/webclient.dart.js:14278:16)
at dart.Primitives_applyFunctionWithPositionalArguments (http://localhost:31337/res/webclient.dart.js:20254:26)
at dart._callDartFunction (http://localhost:31337/res/webclient.dart.js:28884:29)
at http://localhost:31337/res/webclient.dart.js:29124:18
at Object.eval [as css] (eval at (http://localhost:31337/res/webclient.dart.js:29006:42), :3:12)

Using /tg/station code. Time Frozen link of tested code: https://github.com/tgstation/-tg-station/archive/ 191a512501401d4631434d4cff9e3d9e4e3f8eae.zip (go to code/modules/client/client procs.dm and comment out lines 95 and 96
Did the problem NOT occur in any earlier versions?
508.1299 worked

I have asked a few other people to attempt to connect, and they get the same thing, frozen resource download at the end.

You may try connecting at http://www.byond.com/play/75.165.118.244:31337

Oct 8 2015, 10:29 pm (Edited on Oct 8 2015, 11:26 pm)
Lummox JR	The function in question is new to 509.1304, so 1303 should work as a stopgap. I'll look into it. [edit] Also as a stopgap, you could remove the new color options from winsetfn in info.dms until the next release.

Oct 9 2015, 9:15 am (Edited on Oct 9 2015, 9:30 am)

Khyberkitsune

I'm experiencing almost the exact same issue on 1304, except for mine the webclient is stuck at 'Connected to world, downloading client' and never initiates resource transfer. Also, I am unable to connect via Dream Daemon using CTRL+J or by clicking the yellow join icon. I can connect fine using the regular current stable BYOND client.

EDIT: Reverting to 1303 fixes webclient connectivity issues but I am still unable to join locally via Dream Daemon.

Oct 9 2015, 11:09 am
Lummox JR	Lummox JR resolved issue with message: The new info control color options didn't work in some browsers and could cause problems at load time.

Oct 9 2015, 11:10 am
Lummox JR	This was a really weird one. There was a bug in the actual Dart2js compilation of this line: for(name in names) Totally innocuous, but it failed reliably in the compiled JS, and worked fine in Dart directly. Even weirder, the styles being set didn't "take" at load time for some odd reason.