NO_CLIENT_COLOR being present in appearance_flags does not appear to actually prevent client.color from affecting it.
Numbered Steps to Reproduce Problem:
1. Set something's appearance_flags variable to NO_CLIENT_COLOR, either on New() or elsewhere, or in a static define on it's path.
2. Set client.color to something.
3. Observe something's color change.
Code Snippet (if applicable) to Reproduce Problem:
/world
fps=25
icon_size = 32
view=6
/atom
icon = 'icon.dmi'
appearance_flags = NO_CLIENT_COLOR
/mob/icon_state = "mob" //bright red square
/turf/icon_state = "turf" //bright blue square
/obj/icon_state = "obj" //bright green square
/client/New()
. = ..()
color = "#0000FF"
Screenshots for the above snippet:
Map editor, https://puu.sh/l3LkG/621ac07a8c.png
Running, https://puu.sh/l3LlB/7cf22ff4be.png
Expected Results:
All atoms would ignore client.color.
Actual Results:
Atoms change color to client.color regardless of NO_CLIENT_COLOR flag.
Does the problem occur:
Every time? Or how often? Every time, regardless of setting it as a default variable or setting it dynamically in New().
In other games? Yes.
In other user accounts? Yes.
On other computers? Not able to test, but presumably.
When does the problem NOT occur? Not known.
Did the problem NOT occur in any earlier versions? If so, what was the last version that worked? (Visit http://www.byond.com/download/build to download old versions for testing.) Tried 1311 and 1310, neither worked with the above snippet.
Workarounds: None known.
