[Webclient] animate() doing weird things to pixel offsets

ID:2014963
 
Jan 8 2016, 9:38 pm
Resolved
Animations did not handle transitions from existing animations properly.
BYOND Version:509.1318
Operating System:Windows 10 Pro 64-bit
Web Browser:Chrome 47.0.2526.106
Applies to:Webclient
Status: Resolved (510.1323)
This issue has been resolved.
Descriptive Problem Summary:

animate() in the webclient seems to be doing really weird things to pixel offsets...

The relevant code:
                    animate(I, pixel_x = old_px, pixel_y = -48, time = 15, easing = SINE_EASING | EASE_IN)
                    sleep(15)
                    I.layer = OBJ_LAYER

                    animate(I, pixel_y = -32, time = 3, easing = SINE_EASING | EASE_OUT)
                    sleep(3)
                    animate(I, pixel_y = -48, time = 3, easing = SINE_EASING | EASE_IN)
                    sleep(3)
                    animate(I, pixel_y = -40, time = 2, easing = SINE_EASING | EASE_OUT)
                    sleep(2)
                    animate(I, pixel_y = -48, time = 2, easing = SINE_EASING | EASE_IN)
                    sleep(10)
                    P.give_item(item_type)
                    animate(I, alpha = 0, time = 10)



How it currently looks (Webclient): http://i.imgur.com/LQhhxR4.gifv
How it's supposed to look (DS): http://i.imgur.com/KrD4Ig5.gifv

Jan 17 2016, 1:36 pm
Just curious. But, is there something in relation to this bug and your client.eye bug?
Feb 2 2016, 7:41 pm
Bump!
Feb 5 2016, 12:46 pm
Lummox JR resolved issue with message:
Animations did not handle transitions from existing animations properly.
Feb 5 2016, 12:50 pm
Suggested workaround (that will also result in better code):

animate(I, pixel_x = old_px, pixel_y = -48, time = 15, easing = SINE_EASING | EASE_IN)
animate(layer = OBJ_LAYER, time = 0)
animate(pixel_y = -32, time = 3, easing = SINE_EASING | EASE_OUT)
animate(pixel_y = -48, time = 3, easing = SINE_EASING | EASE_IN)
animate(pixel_y = -40, time = 2, easing = SINE_EASING | EASE_OUT)
animate(pixel_y = -48, time = 2, easing = SINE_EASING | EASE_IN)
sleep(33)
P.give_item(item_type)
animate(I, alpha = 0, time = 10)

Doing this as a multi-step animation seems a lot better than doing a bunch of single-steps and sleeping between.

I'm going to introduce QUAD_EASING in the next release which IMO will suit you better than SINE_EASING.