ID:2034005
 
Resolved
Right-click menus didn't respect the correct mouse hit rules for PLANE_MASTER and KEEP_TOGETHER.
BYOND Version:510.1323
Operating System:Windows 10 Home 64-bit
Web Browser:Chrome 48.0.2564.103
Applies to:Dream Seeker
Status: Resolved (510.1324)

This issue has been resolved.
Descriptive Problem Summary:

Right-clicking on the map when a PLANE_MASTER /image is visible will treat it as a right-click to your own mob, regardless of the mouse_opacity of the /image, and any other objects on your tile are also ignored. This makes verb pop-ups only show verbs attached to your mob, nothing else will appear.

Numbered Steps to Reproduce Problem:

1) Use the following code.
2) Throw some mobs and objs on the map.
3) Right-click around, see a popup for your mob appear anywhere.
4) Be unable to get a verb popup from anything else on the map.

Code Snippet (if applicable) to Reproduce Problem:
image
buggy
appearance_flags = PLANE_MASTER
plane = 0

mob
var/tmp/image/buggy/buggy_master
Login()
..()
buggy_master = new(loc=src)
src << buggy_master


verb
Buggy()
set src in view(usr)
usr << "Buggy [src.name]"

ClearMaster()
client.images -= buggy_master

ShowMaster()
src << buggy_master

obj
SomeObj
verb
BuggyToo()
set src in view(usr)
usr << "Very buggy [src.name]"


Expected Results:

Verb popups for any /mob or /obj/SomeObj in view.

Actual Results:

Verb popup for my own mob only.

Does the problem occur:
Every time? Or how often? Every time.
In other games? All tests with a PLANE_MASTER visible.
In other user accounts? Yes.
On other computers? Yes.

When does the problem NOT occur?

When the /image in question is removed from client.images.

Did the problem NOT occur in any earlier versions? If so, what was the last version that worked? (Visit http://www.byond.com/download/build to download old versions for testing.)

Unable to test older betas at the moment, will do later if needed.

Workarounds:

Will experiment with it a bit more later to find out.
Lummox JR resolved issue with message:
Right-click menus didn't respect the correct mouse hit rules for PLANE_MASTER and KEEP_TOGETHER.
Just wanted to add that since this was fixed:

It doesn't hide the clicks to other stuff anymore, but it still registers right clicking anywhere on the screen as right clicking on the mob.

I also don't see my mob icon in the right click menu anymore.

Same project I sent you to test the original bug still applies to test this.
Dang. I got that too late for the 1327 release. It'll have to wait for another day. Please submit a new bug report for that, since I think it's something slightly different.
Hmm, I don't seem to have any project you sent me, or at least I'm not seeing it. I also still need a new bug report.
Apologies, things got a bit hectic for me, I'll get this done today or tomorrow.
I found a test project you sent me a few weeks ago, but I don't think that's it. It doesn't have right-click verbs at all.

When testing right-clicks in my own test project, I don't have any issues. However I'm putting my lighting on a higher plane, not the other way around, so maybe there's a difference in play.