ID:2081823
 
Resolved
BYOND Version:510.1341
Operating System:Windows 10 Pro
Web Browser:Chrome 49.0.2623.112
Applies to:Dream Seeker
Status: Resolved

This issue has been resolved.
Descriptive Problem Summary:
On our codebase we have some very simple code to increase the view size with mousewheel up/down when you are a certain type of mob. Since we upgraded to 510, using this simple method to increase the view size beyond 21 causes letterboxing to occur on the top and bottom of your view.

I can definitely confirm that the view still reads a constant value and not a value that would correspond to a rectangular view.

Here is what a view of size 40 looks like http://puu.sh/oLKsd/bc92a148a0.png. Anything beyond 21 up/down is letterboxed over.

Numbered Steps to Reproduce Problem:
I would have loved to replicate this in a test case but unfortunately I couldn't, compiling and running
https://github.com/d3athrow/vgstation13 and then choosing the 'observe' command and mousewheeling out.

Code Snippet (if applicable) to Reproduce Problem:
This is the only part of our view change code used to cause this problem
/client/MouseWheel(object,delta_x,delta_y,location,control,params)
if(istype(mob,/mob/dead/observer) || buildmode)
if(delta_y > 0)
view--
else
view++
view = max(view,1)
haszoomed = 1
..()


Expected Results:
As shown in the puu.sh I expect the view of the map to be a square the size of 40x40 filling up the whole square

Actual Results:
The view extends to 40 in the horizontal direction but is letterboxed beyond the view of 21 in the vertical direction.

Does the problem occur:
Every time? Or how often?
In other games?
In other user accounts?
On other computers?
It seems to occur for everyone doing it

Did the problem NOT occur in any earlier versions? If so, what was the last version that worked? (Visit http://www.byond.com/download/build to download old versions for testing.)
This occurs ONLY in 510

Workarounds:
None known at the moment
Lummox JR resolved issue
This is the result of a sanity check added in a prior beta build, because trying to display to a size too far beyond what the system is comfortable with can apparently cause problems. The sanity check was set to 120% of screen size in each dimension; I've increased it to 150% for build 1342.