Procs have an off chance of not running

ID:2223744
 
Mar 12 2017, 3:38 pm
Code:
proc/RemoveFromDeckEditor(var/card/A,var/mob/D)

    if(A in D.DE_main_deck)
        D.CleanDEList(D)
        D.DE_main_deck -= A

    if(A in D.DE_side_deck)
        D.CleanDEList(D)
        D.DE_side_deck -= A

    if(A in D.DE_extra_deck)
        D.CleanDEList(D)
        D.DE_extra_deck -= A

    D.ShowActiveList(D)


Problem description:
All the procs work correctly but sometimes there is an off chance, the code will not call the final proc and I know this because I have debug messages in each of the procs saying if they are starting or not. On this random chance, the final proc (D.ShowActiveList(D)) will not start at all but I've put no sleep() or returns anywhere within the code. I'm really confused as to why this is happening with no apparent explanation.
Mar 12 2017, 6:01 pm
My first instinct is that you're running a loop that isn't closing itself in CleanDEList(). I would suggest throwing debug messages inside of CleanDEList() and seeing where it gets stuck. Also, if you haven't already, add:

#define DEBUG 1


to your code to see if you're getting any runtime errors.
Mar 12 2017, 6:49 pm
I am not getting any run time errors and my DEBUG is already set on.
Mar 13 2017, 4:55 am
Could you post the CleanDEList() proc?
Mar 13 2017, 4:58 am
 
    CleanDEList(var/mob/D)
        world.log << "Clearing List"
        for(var/screen_ref/T in D.client.screen)
            if(findtext(T.screen_loc,"list:"))
                Clean(T)
                continue


Clean() is essentially del but it checks if the reference that it's given is valid.
Mar 13 2017, 5:45 am
I have fixed the issue. For some reason, it did a if branch if it was over the same control as itself. Made a check after Mouse Drag was activated to see if the control is over the same control and if it was to end the code immediately.