ID:2354343
 
Code:
Ships taking damage, where icons are updated
if(take_damage_traditionally)
var/obj/effect/adv_shield/theshield =
pick(generator.shields) //sample a random shield for health and stats.
shield_health = theshield.health
max_shield_health = theshield.maxhealth
if(has_shields())
shields_active = 1
icon_state = "[initial(icon_state)]-shield"
else
shields_active = 0
icon_state = initial(icon_state)
if(health <= 0)
destroy(1)
if(pilot)
if(pilot.loc != src)
exit() //pilot has been tele'd out, remove them!


Problem description:
Hi all, so I've got a weird problem and I'm not sure whether it's down to BYOND or myself.
Basically, on our server we're using several icons to represent ships that fly around, and some of them are pretty large (256x256) however, BYOND seems to disagree whenever the icon on this type of object (/obj/structure/overmap) is set to a size above 100 x (seen in the screenshots)

I have tried clean compiling and deleting the rsc as well as switching version of BYOND twice, now I had this problem before, which inexplicably forced me to squash the ships into a 240 x 256 icon (which worked for a time), I then added another ship and that then broke, leaving the ""restriction"" of these smaller icons.

The most baffling part is I only ever touch icons in their code once:

Screenshots:

Fit the first:
https://gyazo.com/c0d76b8b2c5030c23e7a1146c581a135
As you can see on the variable editor, it does seem to have its squashed icon, but it does not display (the smaller ship is irrelevant)
https://gyazo.com/a4f66ffd59ede4fab4d3672ad5720e6a
So I tried editing it to a standard game icon (ratvar) to see if it was corruption within my icons or the way in which they were laid out. This yielded nothing.
And to demonstrate the bizarre size issue, I then edited its icon to another one (166x195 in dimensions)
https://gyazo.com/b1b1dfe7943d03f744672c04bbdd3ea7

Any help would be appreciated, for a general idea of the code here's the github (though the disappearing ships bug is still there, the 240 x 256 icons work on that version, but not mine)

https://github.com/Kmc2000/StarTrek13

Where ship damage is done
https://github.com/Kmc2000/StarTrek13/blob/master/ StarTrek13/Ships/overmap.dm (The icon change is done at line 506)

Info:
Game: Space station 13
Codebase: /Tg/Station (about 1 month out of date)

Thanks.
This issue has been solved. Moving it to a bug report