Deleting an object problem...

ID:268594
 
Sep 4 2004, 9:19 pm
 
    fire
        speed = 3
        density = 1
        icon_state = "zap"
        Bump(atom/A)
            skilldamage = usr.Int
            skilldamage *= 1.3
            SkillAttack()
                        del(src)

TONS of errors when it bumps something. BUT, when I move it to the(delsrc) no errors...
=/
It's not the process... I've taken it out, same problem. =/
#1 Sep 4 2004, 11:37 pm (Edited on Sep 4 2004, 11:45 pm)
The reason you get errors is that you're using usr in a proc...

    fire
        speed = 3
        density = 1
        icon_state = "zap"
        Bump(atom/movable/A)
            if(ismob(A))
                 var/mob/M = A
                 skilldamage = M.Int
                 skilldamage *= 1.3
                 SkillAttack()
                 del(src)
#2 Sep 4 2004, 11:41 pm (Edited on Sep 4 2004, 11:46 pm)
In response to DeathAwaitsU (#1)
Doh.
_>
Teh thank you, Death.
Crap. ._.
Unexpected errors:

<font color = red>Level-Up Test.dm:388:error:A:undefined type
Level-Up Test.dm:388:M :warning: variable defined but not used</font>

Oi. ;_;
Thanks Death
#3 Sep 5 2004, 4:21 am
In response to Hell Ramen (#2)
So are you ok now or not?
#4 Sep 5 2004, 6:46 pm
In response to DeathAwaitsU (#3)
Erm, no...
I keep trying to fix it, but it's leading to more errors. =/
#5 Sep 6 2004, 2:06 am
In response to Hell Ramen (#4)
When you say skilldamage = blah, who does the var belong to and who are you calling skillattack() for? If it's the obj then make sure to put src's there or if it's the usr, then make sure to put M there.
#6 Sep 6 2004, 3:27 am
In response to Hell Ramen (#2)
"A: undefined type"? Sounds like you made a typo when typing <code>atom/movable</code> ... because /atom/movable is always a defined type.

Once that error is fixed, the other one will probably go away too, because M will be counted as "used".
#7 Sep 6 2004, 3:43 am
In response to Crispy (#6)
 
proc
    SkillDamage(mob/A,mob/B,dmg
        var/damage = dmg
        A.HP -= dmg
        view(A) << "[A] hits [B] for [dmg]"
                A << "You hit [B] for [dmg]
        A.DeathCheck(B)

Skill process(Thanks Unknow Person :P)
        fire
            speed = 3
            density = 1
            icon_state = "fire"
            Bump(atom/movable/A)
                if(ismob(A))
                    var/mob/M = A
                        skilldamage = M.Int
                        skilldamage *= 1.3
                        SlillDamage()
                        del(src)

And there's fire.
:(
The Atom error too. =/
Thanks for helping Death.
(Credit goes to Unknown Person for most of the code)
#8 Sep 6 2004, 3:59 am
In response to Hell Ramen (#7)
Your indentation is all over the place, and there are several other problems too:

1. The second-last line of the SkillDamage proc that you displayed is indented too far. Bring it into line with the lines before and after it.

2. Everything in the "fire" bit after the "var/mob/M = A" line is indented too far. Bring it into line with the "var/mob/M = A" line.

3. You're missing a closing bracket ) on the end of the "SkillDamage(mob/A,mob/B,dmg" line.

4. You misspelt "SkillDamage()" as "SlillDamage()" in the fire bit.

I'm surprised you weren't getting many more compilation errors from that than you were.
#9 Sep 6 2004, 4:00 am
In response to Hell Ramen (#7)
You're doing a lot of things wrong

proc
    SkillDamage(mob/A,mob/B,dmg)
        //i added closing bracket here
        var/damage = dmg
        A.HP -= dmg
        view(A) << "[A] hits [B] for [dmg]"
        A << "You hit [B] for [dmg]
        A.DeathCheck(B)



        fire
            var/owner //this will tell it who fired this
            speed = 3
            density = 1
            icon_state = "fire"
            Bump(atom/movable/A)
                if(ismob(A))
                    var/mob/M = A
                    skilldamage = M.Int
                    skilldamage *= 1.3
                    SkillDamage(owner,M,50)//i renamed this to SkillDamage
                    //We've sent SkillDamage info 
                    //Owner is the person who fired this
                    //M is the person that got Bumped
                    //50 is the damage
                    del(src)


I dont know how you're moving fire but when you do, make sure to do this:

mob/verb/Fire()
     var/obj/fire/F = new
     F.owner = usr//the key line
     F.fire()//this is how you made the obj move


You nmay still be confused but feel free to ask

#10 Sep 6 2004, 4:33 am
In response to Crispy (#8)
I had it surrounded by /* and */ and tried modifying an older version. So, no errors. ;O
Thanks...
_> But it doesn't delete now.