ID:860395
 
BYOND Version:495
Operating System:Linux
Web Browser:Chrome 20.0.1132.47
Applies to:DM Language
Status: Unverified

Thus far we've been unable to verify or reproduce this bug. Or, it has been observed but it cannot be triggered with a reliable test case. You can help us out by editing your report or adding a comment with more information.
Descriptive Problem Summary:
The BYOND hub reports that port 6200 is reachable.
(173.80.29.168)thunderz the Saiyan entered.
BUG: Finished erasure with refcount=1 (ref=3:26) DM (:65535)
(173.80.29.168)thunderz the Saiyan entered.

Numbered Steps to Reproduce Problem:

Code Snippet (if applicable) to Reproduce Problem:
        StartLogin()
src << mb_msgout("\n[worldname]\nLast Compile: 07-09-12 @ 12:45 PM EST")
src.name=input("Name:", "Drag(*)nBall Z Epic Login") as text
if(src.TextAbuseCheck(name))
src << mb_msgout("{YYour name must not start or end with a space nor can it be blank!{x")
del(src)
if(fexists("database/players/[ckey(lowertext(name))]/data.sav"))
var/savefile/F=new("database/players/[ckey(lowertext(name))]/data.sav")
var/gotit
F["Password"]>>gotit
var/pass=input("Password:", "Drag(*)nBall Z Epic Login") as password
if(pass==gotit)
src.Read(F)
src.ProcessLogin()
else
src << mb_msgout("{YIncorrect password!{x")
del(src)
else
if(src.ConfirmName())
else
src << mb_msgout("{YPlease reconnect!")
del(src)
password
src.Password=input("Enter a password for your character.", "Drag(*)nBall Z Epic Login") as password
if(src.TextAbuseCheck(Password))
src << mb_msgout("{YYour password must not start or end with a space nor can it be blank!{x")
del(src)
var/correctpass=input("Please enter it again.", "Drag(*)nBall Z Epic Login") as password
if(correctpass==Password)
src.NewEmail()
src.NewRace()
src.NewGender()
src.NewAlignment()
else
src << "The two passwords did not match. Enter them both again."
goto password


Expected Results:
Character should login after entering password

Actual Results:
As you try to login it logs you out and you have to login twice to get in.

Does the problem occur:
Every time? Or how often?
random
In other games?
In other user accounts?
On other computers?

When does the problem NOT occur?

Did the problem NOT occur in any earlier versions? If so, what was the last version that worked? (Visit http://www.byond.com/download/build to download old versions for testing.)

Workarounds:

This isn't enough code to really see what's going on in the login process. One thing I can tell reliably from it is that you're misusing goto--you should be using a while loop instead. Fixing that won't affect anything; it's just really bad style. Save goto for situations where nothing else works well.

As for the bug itself, there's only one bug here: The erasure of the mob where a reference was left behind. The fact that it's not logging in the first time seems like it's a problem in your code. The fact that you're calling Read() directly is kind of another no-no and could be the cause of your login issues, though it's probably unlikely to be related to the refcount bug.
Lummox JR changed status to 'Unverified'