I think making @ valid for ckey() is a bad idea at this point in BYOND's development, and has probably just introduced bugs into existing games; too many things already depend on it passing only alphanumerics. This could easily screw up my language filter, for example.

Lummox JR wrote:

I think making @ valid for ckey() is a bad idea at this point in BYOND's development, and has probably just introduced bugs into existing games; too many things already depend on it passing only alphanumerics. This could easily screw up my language filter, for example.

Note that '@' is not a valid key character, so you should never get in a situation where ckey(mob.key) will return the @ symbol, potentially causing problems with parsers. I believe Dan just made this change for telnet support.

Lummox JR wrote:

I think making @ valid for ckey() is a bad idea at this point in BYOND's development, and has probably just introduced bugs into existing games; too many things already depend on it passing only alphanumerics. This could easily screw up my language filter, for example.

Note that '@' is not a valid key character, so you should never get in a situation where ckey(mob.key) will return the @ symbol, potentially causing problems with parsers.

The trouble is, key comparisons are done internally on the canonical key value. It doesn't do me any good to have extra options in ckey() unless those are also the default options implied when comparing keys.

I wanted there to be some way to produce key values that fall outside of the BYOND keyspace, both for telnet worlds and for hubfile games involving place-holder users who have been invited by email.

I can live without this change, but I thought about it a fair amount and figured it wouldn't cause any problems in existing applications. Can you give me an example of the sort of thing it has messed up?

proc/CussScore(msg)
  var/score=0
  var/index
  var/cussword
  for(cussword in admin.any_cuss)     // this can occur even as part of a word
    index=findtext(msg,cussword)
    while(index)
      score+=admin.any_cuss[cussword]
      index=findtext(msg,cussword,index+length(cussword))
  for(cussword in admin.whole_cuss)   // this must be a whole word
    index=findtext(msg,cussword)
    while(index)
      var/beforeindex=max(1,index-1)                            // start of context
      var/afterindex=min(index+length(cussword),length(msg))+1  // end+1 of context
                  var/context=copytext(msg,beforeindex,afterindex)
      if(ckey(cussword)==ckey(context))
        score+=admin.whole_cuss[cussword]
      index=findtext(msg,cussword,index+length(cussword))
  return score

The trouble is, key comparisons are done internally on the canonical key value. It doesn't do me any good to have extra options in ckey() unless those are also the default options implied when comparing keys.

Why not just write that this is the default in the reference?