Weapon Equip Problem

ID:143689
 
Jul 26 2007, 6:18 am
Code:
        DblClick()
            if (!src.suffix)
                var/CanEquip = 0
                for (var/A in ClassReq)
                    if (usr.Class == A)
                        CanEquip = 1
                if (!CanEquip)
                    usr << "Your class cannot equip this item!"
                    return
                if (usr.Level < LevelReq)
                    usr << "You are not yet experienced enough for this weapon."
                    return
                if (usr.Class != "Rogue" || usr.Class != "Assassin" || usr.Class != "Assassin Cross" || usr.Specialty != "Blademaster")
                    for (var/obj/equipment/Weapons/W in usr)
                        if (W.suffix == "(Equipped)")
                            usr << "You remove your [W]."
                            W.suffix = null
                            usr.Weapon = null
                            usr.Strength -= StrBonus
                            usr.Vitality -= VitBonus
                            usr.Agility -= AgiBonus
                            usr.Knowledge -= KnoBonus
                            usr.Wisdom -= WisBonus
                            usr.MaxHp -= HPBonus
                            usr.MaxEnergy -= ENBonus
                            usr.MaxMana -= MPBonus
                            usr.AttackText = "punches"
                    usr << "You equip your [src]."
                    usr.AttackText = AttackText
                    usr.Weapon = Power
                    usr.Strength += StrBonus
                    usr.Vitality += VitBonus
                    usr.Agility += AgiBonus
                    usr.Knowledge += KnoBonus
                    usr.Wisdom += WisBonus
                    usr.MaxHp += HPBonus
                    usr.MaxMana += MPBonus
                    usr.MaxEnergy += ENBonus
                    src.suffix = "(Equipped)"
                else
                    var/HandChoice = alert("Equip in which hand?", "Equip Weapon", "Left", "Right")
                    if (HandChoice == "Right")
                        for (var/obj/equipment/Weapons/W in usr)
                            if (W.suffix == "(Equipped)" && W.HandEquipped == "Right")
                                usr << "You remove your [W]."
                                W.suffix = null
                                usr.Weapon = null
                                usr.Strength -= StrBonus
                                usr.Vitality -= VitBonus
                                usr.Agility -= AgiBonus
                                usr.Knowledge -= KnoBonus
                                usr.Wisdom -= WisBonus
                                usr.MaxHp -= HPBonus
                                usr.MaxMana -= MPBonus
                                usr.MaxEnergy -= ENBonus
                                HandEquipped = null
                                if (!usr.Weapon && ! usr.Weapon2)
                                    usr.AttackText = "punches"
                        usr << "You equip your [src]."
                        usr.AttackText = AttackText
                        usr.Weapon = Power
                        usr.Strength += StrBonus
                        usr.Vitality += VitBonus
                        usr.Agility += AgiBonus
                        usr.Knowledge += KnoBonus
                        usr.Wisdom += WisBonus
                        usr.MaxHp += HPBonus
                        usr.MaxMana += MPBonus
                        usr.MaxEnergy += ENBonus
                        HandEquipped = "Right"
                        src.suffix = "(Equipped)"
                    else
                        for (var/obj/equipment/Weapons/W in usr)
                            if (W.suffix == "(Equipped)" && W.HandEquipped == "Left")
                                usr << "You remove your [W]."
                                W.suffix = null
                                usr.Weapon2 = null
                                usr.Strength -= StrBonus
                                usr.Vitality -= VitBonus
                                usr.Agility -= AgiBonus
                                usr.Knowledge -= KnoBonus
                                usr.Wisdom -= WisBonus
                                usr.MaxHp -= HPBonus
                                usr.MaxMana -= MPBonus
                                usr.MaxEnergy -= ENBonus
                                HandEquipped = null
                                if (!usr.Weapon && ! usr.Weapon2)
                                    usr.AttackText = "punches"
                        usr << "You equip your [src]."
                        usr.AttackText = AttackText
                        usr.Weapon2 = Power
                        usr.Strength += StrBonus
                        usr.Vitality += VitBonus
                        usr.Agility += AgiBonus
                        usr.Knowledge += KnoBonus
                        usr.Wisdom += WisBonus
                        usr.MaxHp += HPBonus
                        usr.MaxMana += MPBonus
                        usr.MaxEnergy += ENBonus
                        HandEquipped = "Left"
                        src.suffix = "(Equipped)"

            else
                if (usr.Class != "Rogue" || usr.Class != "Assassin" || usr.Class != "Assassin Cross" || usr.Specialty != "Blademaster")
                    usr << "You remove your [src]."
                    src.suffix = null
                    usr.Weapon = null
                    usr.Strength -= StrBonus
                    usr.Vitality -= VitBonus
                    usr.Agility -= AgiBonus
                    usr.Knowledge -= KnoBonus
                    usr.Wisdom -= WisBonus
                    usr.MaxHp -= HPBonus
                    usr.MaxMana -= MPBonus
                    usr.MaxEnergy -= ENBonus
                    usr.AttackText = "punches"
                else
                    if (usr.Weapon == Power)
                        usr << "You remove your [src]."
                        src.suffix = null
                        usr.Weapon = null
                        usr.Strength -= StrBonus
                        usr.Vitality -= VitBonus
                        usr.Agility -= AgiBonus
                        usr.Knowledge -= KnoBonus
                        usr.Wisdom -= WisBonus
                        usr.MaxHp -= HPBonus
                        usr.MaxMana -= MPBonus
                        usr.MaxEnergy -= ENBonus
                        HandEquipped = null
                        if (!usr.Weapon && ! usr.Weapon2)
                            usr.AttackText = "punches"
                    else
                        usr << "You remove your [src]."
                        src.suffix = null
                        usr.Weapon2 = null
                        usr.Strength -= StrBonus
                        usr.Vitality -= VitBonus
                        usr.Agility -= AgiBonus
                        usr.Knowledge -= KnoBonus
                        usr.Wisdom -= WisBonus
                        usr.MaxHp -= HPBonus
                        usr.MaxMana -= MPBonus
                        usr.MaxEnergy -= ENBonus
                        HandEquipped = null
                        if (!usr.Weapon && ! usr.Weapon2)
                            usr.AttackText = "punches"


Problem description:
I had this problem fixed a long time ago, but me being the person I am and not archiving my code; lost it and had to revert back to an older version. But, the problem is that I can't seem to get all of the classes/specialty to dual equip. The code works fine when it's just rogue all by it's self, but none of them can equip if I have more than one class in there. Hopefully I can get a little help.
Jul 28 2007, 1:02 pm
I guess this is pretty much a bump, seeing as how I would like to get this working on my game as soon as possible. Any help would be nice. Thank you in advance.
Jul 29 2007, 5:36 am
In response to Akiyo
Youre code is really long. Can you give a shorter snippet more zoomed in on what you think is the source of the problem?
Jul 29 2007, 8:49 am
 
obj
    DblClick()
        if(!suffix)
            var/CanEquip=0
            for(var/A in ClassReq)
                if(usr.Class==A)usr.CanEquip=1
            if(!CanEquip||usr.Level<LevelReq){usr<<"[!CanEquip? "Your class cannot equip this item!" : "You are not yet experienced enough for this weapon."]";return}
            if(usr.Class=="Rouge"||usr.Class=="Assassin"||usr.Class=="Assassin Cross"||usr.Speciality=="Blademaster")
                switch(input(usr,"Equip In Which hand?","Equip Weapon") in list("Left","Right"))
                    if("Right")
                        for(var/obj/equipment/Weapons/W in usr.contents)
                            if(W.suffix=="(Equipped)"&&W.HandEquipped=="Right")
                                usr<<"You remove your [W.name]"
                                usr << "You remove your [W]."
                                W.suffix = null
                                usr.Weapon = null
                                usr.Strength -= StrBonus
                                usr.Vitality -= VitBonus
                                usr.Agility -= AgiBonus
                                usr.Knowledge -= KnoBonus
                                usr.Wisdom -= WisBonus
                                usr.MaxHp -= HPBonus
                                usr.MaxMana -= MPBonus
                                usr.MaxEnergy -= ENBonus
                                HandEquipped = null
                                if(!usr.Weapon && ! usr.Weapon2)usr.AttackText = "punches"
                            usr << "You equip your [src]."
                            usr.AttackText = AttackText
                            usr.Weapon = Power
                            usr.Strength += StrBonus
                            usr.Vitality += VitBonus
                            usr.Agility += AgiBonus
                            usr.Knowledge += KnoBonus
                            usr.Wisdom += WisBonus
                            usr.MaxHp += HPBonus
                        usr.MaxMana += MPBonus
                        usr.MaxEnergy += ENBonus
                        HandEquipped = "Right"
                        suffix = "(Equipped)"
                    if("Left")
                        for(var/obj/equipment/Weapons/W in usr.contents)
                            if(W.suffix=="(Equipped)"&&W.HandEquipped=="Left")
                                usr<<"You remove your [W.name]"
                                usr << "You remove your [W]."
                                W.suffix = null
                                usr.Weapon = null
                                usr.Strength -= StrBonus
                                usr.Vitality -= VitBonus
                                usr.Agility -= AgiBonus
                                usr.Knowledge -= KnoBonus
                                usr.Wisdom -= WisBonus
                                usr.MaxHp -= HPBonus
                                usr.MaxMana -= MPBonus
                                usr.MaxEnergy -= ENBonus
                                HandEquipped = null
                                if(!usr.Weapon && ! usr.Weapon2)usr.AttackText = "punches"
                            usr << "You equip your [src]."
                            usr.AttackText = AttackText
                            usr.Weapon = Power
                            usr.Strength += StrBonus
                            usr.Vitality += VitBonus
                            usr.Agility += AgiBonus
                            usr.Knowledge += KnoBonus
                            usr.Wisdom += WisBonus
                            usr.MaxHp += HPBonus
                        usr.MaxMana += MPBonus
                        usr.MaxEnergy += ENBonus
                        HandEquipped = "Left"
                        suffix = "(Equipped)"
            else for(var/obj/equipment/Weapons/W in usr.contents)
                if(W.suffix == "(Equipped)")
                    usr << "You remove your [W]."
                    W.suffix = null
                    usr.Weapon = null
                    usr.Strength -= StrBonus
                    usr.Vitality -= VitBonus
                    usr.Agility -= AgiBonus
                    usr.Knowledge -= KnoBonus
                    usr.Wisdom -= WisBonus
                    usr.MaxHp -= HPBonus
                    usr.MaxEnergy -= ENBonus
                    usr.MaxMana -= MPBonus
                    usr.AttackText = "punches"
                usr << "You equip your [src]."
                usr.AttackText = AttackText
                usr.Weapon = Power
                usr.Strength += StrBonus
                usr.Vitality += VitBonus
                usr.Agility += AgiBonus
                usr.Knowledge += KnoBonus
                usr.Wisdom += WisBonus
                usr.MaxHp += HPBonus
                usr.MaxMana += MPBonus
                usr.MaxEnergy += ENBonus
                suffix = "(Equipped)"
    else
        if(usr.Class=="Rouge"||usr.Class=="Assassin"||usr.Class=="Assassin Cross"||usr.Speciality=="Blademaster")
            if(usr.Weapon == Power)
                usr << "You remove your [src]."
                suffix = null
                usr.Weapon = null
                usr.Strength -= StrBonus
                usr.Vitality -= VitBonus
                usr.Agility -= AgiBonus
                usr.Knowledge -= KnoBonus
                usr.Wisdom -= WisBonus
                usr.MaxHp -= HPBonus
                usr.MaxMana -= MPBonus
                usr.MaxEnergy -= ENBonus
                HandEquipped = null
                if(!usr.Weapon && ! usr.Weapon2)usr.AttackText = "punches"
            else
                usr << "You remove your [src]."
                suffix = null
                usr.Weapon2 = null
                usr.Strength -= StrBonus
                usr.Vitality -= VitBonus
                usr.Agility -= AgiBonus
                usr.Knowledge -= KnoBonus
                usr.Wisdom -= WisBonus
                usr.MaxHp -= HPBonus
                usr.MaxMana -= MPBonus
                usr.MaxEnergy -= ENBonus
                HandEquipped = null
                if(!usr.Weapon && ! usr.Weapon2)usr.AttackText = "punches"
        else
            usr << "You remove your [src]."
            suffix = null
            usr.Weapon2 = null
            usr.Strength -= StrBonus
            usr.Vitality -= VitBonus
            usr.Agility -= AgiBonus
            usr.Knowledge -= KnoBonus
            usr.Wisdom -= WisBonus
            usr.MaxHp -= HPBonus
            usr.MaxMana -= MPBonus
            usr.MaxEnergy -= ENBonus
            HandEquipped = null
            if(!usr.Weapon && ! usr.Weapon2)usr.AttackText = "punches"


I slightly Revised your code...it should work. using != with a text strng does not work properly(it seems like that whenever i used to use it.) so insead you should check to see that the class is rouge etc. you might have to ajust indentation to your needs.
Jul 29 2007, 8:54 am
In response to Learned
Learned wrote:
Youre code is really long. Can you give a shorter snippet more zoomed in on what you think is the source of the problem?

     DblClick()
            if (!src.suffix)
                var/CanEquip = 0
                for (var/A in ClassReq)
                    if (usr.Class == A)
                        CanEquip = 1
                if (!CanEquip)
                    usr << "Your class cannot equip this item!"
                    return
                if (usr.Level < LevelReq)
                    usr << "You are not yet experienced enough for this weapon."
                    return
                if (usr.Class != "Rogue" || usr.Class != "Assassin" || usr.Class != "Assassin Cross" || usr.Specialty != "Blademaster")
                    for (var/obj/equipment/Weapons/W in usr)
                        if (W.suffix == "(Equipped)")
                            usr << "You remove your [W]."
                            W.suffix = null
                            usr.Weapon = null
                            usr.Strength -= StrBonus
                            usr.Vitality -= VitBonus
                            usr.Agility -= AgiBonus
                            usr.Knowledge -= KnoBonus
                            usr.Wisdom -= WisBonus
                            usr.MaxHp -= HPBonus
                            usr.MaxEnergy -= ENBonus
                            usr.MaxMana -= MPBonus
                            usr.AttackText = "punches"
                    usr << "You equip your [src]."
                    usr.AttackText = AttackText
                    usr.Weapon = Power
                    usr.Strength += StrBonus
                    usr.Vitality += VitBonus
                    usr.Agility += AgiBonus
                    usr.Knowledge += KnoBonus
                    usr.Wisdom += WisBonus
                    usr.MaxHp += HPBonus
                    usr.MaxMana += MPBonus
                    usr.MaxEnergy += ENBonus
                    src.suffix = "(Equipped)"


That is the jest of the problem, and the second half has the same problem; Mainly the problem is withing the classes, being that before I had only Rogue and it would work fine. But, now it won't work at all. I have tried replacing != with == but it doesn't seem to work that way either. When I get more time I will do what Axerob suggested.
Jul 29 2007, 9:04 am
In response to Akiyo
i already fixed the problem for you in the code i posted >_>
Jul 29 2007, 9:05 am
In response to Axerob
Ah, I figured you just reposted. Nevermind then. >_>
Jul 29 2007, 9:08 am
In response to Akiyo
....XD now go update.
Jul 29 2007, 9:48 am
In response to Axerob
Heh, even after fitting your coding to my indentation methods. I get 143 errors now; after fixing that up, it still doesn't work.
Jul 29 2007, 10:25 am
In response to Akiyo
o.O......yeah...143?