Of course there's also the problem of sometimes ME getting unorganized with all my code condensed so much. I have to study not only the context of the code I've written when I forget something, but also the syntax. There's also of course the huge pro to condensing everything; it's faster, and easier to type down at first. Here's an example of what a typical person would consider "readable":
switch(protection)
if(YES)
src << "You aren't a dirty pig!"
if(NO)
src << "You are a dirty pig!"
if(WHAT_IS_PROTECTION)
src << "What is protection?!"
var/list/responses = list()
for(var/mob/M in world)
spawn()
responses.Add(input("What do you think is protection?") as text)
sleep(500)
src << "The populace thinks \"[pick(responses)]\" is protection!"
And here's MY normal approach:
switch(protection)
if(YES) src<<"You aren't a dirty pig!"
if(NO) src<<"You are a dirty pig!"
if(WHAT_IS_PROTECTION)
src<<"What is protection?!"
var/list/responses=list()
for(var/mob/M in world)
spawn() responses.Add(input("What do you think if protection?") as text)
sleep(500)
src<<"The populace thinks \"[pick(responses)]\" is protection! Oh and your code is UNREADABLE AAAUURGH!!"
There's a significant difference in the amount of time it took me to type the condensed version. But the real question is; which is more practical/efficient in the long run?
With your approach it would be lets say 4 lines for each calculation (Strength, Endurance, Defense, Skills, Equipment) ending up in 20 lines.
Later on when something happens, it'll be hard to determine where is what. (at least for me)
With that "readable style" you would end up with 25-30 lines, but later on you'll be able to tell difference easily where calculation for Defense begins, and where it ends, as you'll have spacing which will separate these calculations.