overcome image pop-in?

ID:1917751
 
Aug 14 2015, 6:32 pm
(See the best response by Doohl.)
How can i keep this from happening. 'this' being the pop-in for the image on the left client.


code:
/spell/aoe_turf/fall
    name = "Mass Sleep"
    desc = "This spell puts any organic being to sleep for a short period in a large radius around you."

    spell_flags = NEEDSCLOTHES

    selection_type = "range"
    school = "transmutation"
    charge_max = 2100 // 3.5min
    invocation = "OMNIA RUINAM"
    invocation_type = SpI_WHISPER
    range = 7
    cooldown_min = 2100
    cooldown_reduc = 0
    level_max = list(Sp_TOTAL = 0, Sp_SPEED = 0, Sp_POWER = 0)
    hud_state = "wiz_sleep"
    var/image/aoe_underlay
    var/list/oureffects = list()
    

/spell/aoe_turf/fall/New()
    ..()
    buildimage()

/spell/aoe_turf/fall/proc/buildimage()
    aoe_underlay = image(icon = 'icons/effects/640x640.dmi', icon_state = "fall", layer = 2.1)
    aoe_underlay.transform /= 50
    aoe_underlay.pixel_x = -304
    aoe_underlay.pixel_y = -304
    aoe_underlay.mouse_opacity = 0

/spell/aoe_turf/fall/cast(list/targets)
    spawn(120)
        del(aoe_underlay)
        buildimage()
    spawn()
        aoe_underlay.loc = get_turf(usr)
        for(var/client/C in clients)
            C << aoe_underlay
        animate(aoe_underlay, transform = null, time = 2)
    playsound(usr, 'sound/effects/fall.ogg', 100, 0, 0, 0, 0)
    spawn(3)
        var/sleepfor = world.time + 100
        for(var/turf/T in targets)
            oureffects += getFromPool(/obj/effect/sleeping, T, sleepfor, usr:mind)
            for(var/mob/living/L in T)
                spawn()
                    if(L == usr) continue
                    L.playsound_local(L, 'sound/effects/fall2.ogg', 100, 0, 0, 0, 0)
                    L.Paralyse(5)
        return

/spell/aoe_turf/fall/after_cast(list/targets)
    spawn(100)
        animate(aoe_underlay, transform = aoe_underlay.transform / 50, time = 2)
        for(var/obj/effect/sleeping/S in oureffects)
            returnToPool(S)
            oureffects -= S
    return
Aug 14 2015, 6:49 pm
Best response
Short of splitting up the effect into multiple smaller segments or increasing the client's view size, I can't think of a way to prevent the pop-in.
Aug 14 2015, 7:05 pm
The client won't render anything who's loc is not within a certain range of the view. There's not really much of a soft workaround with it. The only other advice would be what Doohl suggested.
Aug 14 2015, 7:36 pm
apparently already had a nasty workaround in the codebase that i missed somehow,
/spell/aoe_turf/fall/cast(list/targets)
    /*spawn(120)
        del(aoe_underlay)
        buildimage()*/
    spawn()
        var/turf/T = get_turf(usr)
        for(var/client/C in clients)
            if(C.mob)
                C.mob.see_fall(T)
        //animate(aoe_underlay, transform = null, time = 2)
    playsound(usr, 'sound/effects/fall.ogg', 100, 0, 0, 0, 0)
    spawn(3)
        var/sleepfor = world.time + 100
        for(var/turf/T in targets)
            oureffects += getFromPool(/obj/effect/sleeping, T, sleepfor, usr:mind)
            for(var/mob/living/L in T)
                spawn()
                    if(L == usr) continue
                    L.playsound_local(L, 'sound/effects/fall2.ogg', 100, 0, 0, 0, 0)
                    L.Paralyse(5)
        return

/spell/aoe_turf/fall/after_cast(list/targets)
    spawn(100)
        //animate(aoe_underlay, transform = aoe_underlay.transform / 50, time = 2)
        for(var/client/C in clients)
            if(C.mob)
                C.mob.see_fall()
        for(var/obj/effect/sleeping/S in oureffects)
            returnToPool(S)
            oureffects -= S
    return

/mob/var/image/fallimage

/mob/proc/see_fall(var/turf/T)
    var/turf/T_mob = get_turf(src)
    if(!T && fallimage)
        animate(fallimage, transform = fallimage.transform / 50, time = 2)
        sleep(2)
        del(fallimage)
        return
    if((T.z == T_mob.z) && (get_dist(T,T_mob) <= 15))// &&!(T in view(T_mob)))
        if(!fallimage)
            fallimage = image(icon = 'icons/effects/640x640.dmi', icon_state = "fall", layer = 2.1)
            fallimage.transform /= 50
            fallimage.mouse_opacity = 0

        var/new_x = 32 * (T.x - T_mob.x) - 304
        var/new_y = 32 * (T.y - T_mob.y) - 304
        fallimage.pixel_x = new_x
        fallimage.pixel_y = new_y
        fallimage.loc = T_mob

        src << fallimage
        animate(fallimage, transform = null, time = 2)