ID:2101582
 
Resolved
Regression: When SEE_PIXELS was used, mouse behavior could break completely.
BYOND Version:510
Operating System:Windows 10 Pro
Web Browser:Chrome 51.0.2704.84
Applies to:Dream Seeker
Status: Resolved (510.1347)

This issue has been resolved.
Descriptive Problem Summary:
In 1346 we got the much appreciated fixes to two of SEE_PIXELS behaviors.

However they have spawned a breaking change, when using SEE_PIXELS without any of
SEE_TURFS
SEE_OBJS
SEE_MOBS
all click behavior is prevented on everything in and out of view

Numbered Steps to Reproduce Problem:
1. Give a mob SEE_PIXELS to reproduce the issue
2. Give them one of the other 3 main sight flags to stop it from occurring

Code Snippet (if applicable) to Reproduce Problem:
/atom/Click()
..()
world << "clicked [x],[y],[z]"

/client/verb/rightclick1(datum/D in world)
set name = "rightclick1"

/client/verb/rightclick2(atom/A as mob|turf|obj)
set name = "rightclick2"

/client/verb/testsight()
set name = "Change sight vars"
mob.sight = 0
mob << "Sight vars reset, preparing to add new sight vars"

var/alert1 = alert("Add SEE_PIXELS flag?", "TEST SIGHT", "yes", "no")
if(alert1 == "yes")
mob.sight |= SEE_PIXELS
mob << "SEE_PIXELS added to sight vars"

var/alert2 = alert("Add SEE_TURFS flag?", "TEST SIGHT", "yes", "no")
if(alert2 == "yes")
mob.sight |= SEE_TURFS
mob << "SEE_TURFS added to sight vars"

var/alert3 = alert("Add SEE_OBJS flag?", "TEST SIGHT", "yes", "no")
if(alert3 == "yes")
mob.sight |= SEE_OBJS
mob << "SEE_OBJS added to sight vars"

var/alert4 = alert("Add SEE_MOBS flag?", "TEST SIGHT", "yes", "no")
if(alert4 == "yes")
mob.sight |= SEE_MOBS
mob << "SEE_MOBS added to sight vars"

var/alert5 = alert("Add SEE_SELF flag?", "TEST SIGHT", "yes", "no")
if(alert5 == "yes")
mob.sight |= SEE_SELF
mob << "SEE_SELF added to sight vars"


Expected Results:
Click behavior is allowed on objs|turfs|mobs in view when SEE_PIXELS is enabled and no extra sight flags are added.

Actual Results:
Click behavior is prevented at the moment on all objs|turfs|mobs regardless of vision when SEE_PIXELS is the only sight flag

Did the problem NOT occur in any earlier versions? If so, what was the last version that worked? (Visit http://www.byond.com/download/build to download old versions for testing.)
Directly caused by the changes made to fix see pixels bugs in 1346
Oh, crap. I see where this went wrong.
Lummox JR resolved issue with message:
Regression: When SEE_PIXELS was used, mouse behavior could break completely.