ID:2326765
 
Resolved
Certain operations like grabbing drag/drop pointers could result in a crash.
BYOND Version:512.1399
Operating System:Windows 10 Home 64-bit
Web Browser:Chrome 63.0.3239.84
Applies to:Dream Seeker
Status: Resolved (512.1400)

This issue has been resolved.
Descriptive Problem Summary:

I haven't been able to narrow this down to a test case, but it's easily reproducible for me playing Spires of Agartha. When dragging an item from a screen object to another screen object the client will crash with the following event viewer output:

Faulting application name: dreamseeker.exe, version: 5.0.512.1399, time stamp: 0x5a32ede9
Faulting module name: byondcore.dll, version: 5.0.512.1399, time stamp: 0x5a32ed7e
Exception code: 0xc0000005
Fault offset: 0x000417e8
Faulting process id: 0x2b8c
Faulting application start time: 0x01d37623980eb596
Faulting application path: C:\Program Files (x86)\BYOND\bin\dreamseeker.exe
Faulting module path: C:\Program Files (x86)\BYOND\bin\byondcore.dll
Report Id: beedfef7-c5d4-44e7-b618-3054d0edbbff
Faulting package full name:


And

Fault bucket , type 0
Event Name: APPCRASH
Response: Not available
Cab Id: 0

Problem signature:
P1: dreamseeker.exe
P2: 5.0.512.1399
P3: 5a32ede9
P4: byondcore.dll
P5: 5.0.512.1399
P6: 5a32ed7e
P7: c0000005
P8: 000417e8
P9:
P10:

Attached files:
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER21CC.tmp.dmp
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER4341.tmp.WERInternalMetadata.xml
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER438D.tmp.csv
\\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER43FB.tmp.txt

These files may be available here:
C:\ProgramData\Microsoft\Windows\WER\ReportArchive\AppCrash_dreamseeker.exe_8799da40d6fe595289f8436f1343130bea3432f_3b77859e_08b14daf

Analysis symbol:
Rechecking for solution: 0
Report Id: beedfef7-c5d4-44e7-b618-3054d0edbbff
Report Status: 97


Numbered Steps to Reproduce Problem:

1) Open Spires of Agartha, get an item in your inventory, attempt to drag/drop said item anywhere.

Code Snippet (if applicable) to Reproduce Problem:


Expected Results:

No crash.

Actual Results:

Kaboom.

Does the problem occur:
Every time? Or how often? Every time.
In other games? Unsure
In other user accounts? Yes.
On other computers? Yes.

When does the problem NOT occur?

On 1398 and below.

Did the problem NOT occur in any earlier versions? If so, what was the last version that worked? (Visit http://www.byond.com/download/build to download old versions for testing.)

New to 1399.

Workarounds:

Don't use 1399.
Lummox JR resolved issue with message:
Certain operations like grabbing drag/drop pointers could result in a crash.
I found the problem.

In the optimization of GetCappearanceItileList() I removed a bunch of sanity checks on the icon list pointer, because everywhere I looked that was never null. Turns out I missed a few cases even with all that searching, and some of them were indirect.