ID:2476501
 
Resolved
Animations could cause crashes in unusual circumstances.
BYOND Version:512
Operating System:Windows 8 Pro 64-bit
Web Browser:Firefox 67.0
Applies to:Dream Seeker
Status: Resolved (512.1471)

This issue has been resolved.
Descriptive Problem Summary: Dream seeker crashes when observing explosions in SS13, reported by multiple users and reproducible

Numbered Steps to Reproduce Problem:
SS13 https://github.com/tgstation/tgstation version.
Use Drop-Bomb verb repeateadly.
The crash doesn't happen every time but pretty frequently.(5 max explosions seem to trigger it every time for me)

Log Name:      Application
Source: Application Error
Date: 6/13/2019 11:25:00 AM
Event ID: 1000
Task Category: (100)
Level: Error
Keywords: Classic
User: N/A
Computer: AR-PC
Description:
Faulting application name: dreamseeker.exe, version: 5.0.512.1470, time stamp: 0x5ceae31d
Faulting module name: byondcore.dll, version: 5.0.512.1470, time stamp: 0x5ceae2aa
Exception code: 0xc0000005
Fault offset: 0x0002ecb9
Faulting process id: 0x1a04
Faulting application start time: 0x01d521c98ea6fe90
Faulting application path: D:\Games\BYOND\bin\dreamseeker.exe
Faulting module path: D:\Games\BYOND\bin\byondcore.dll
Report Id: 1d4b2b39-8dbd-11e9-82c8-408d5c1e6281
Faulting package full name:
Faulting package-relative application ID:
Event Xml:
<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
<System>
<Provider Name="Application Error" />
<EventID Qualifiers="0">1000</EventID>
<Level>2</Level>
<Task>100</Task>
<Keywords>0x80000000000000</Keywords>
<TimeCreated SystemTime="2019-06-13T09:25:00.000000000Z" />
<EventRecordID>762329</EventRecordID>
<Channel>Application</Channel>
<Computer>AR-PC</Computer>
<Security />
</System>
<EventData>
<Data>dreamseeker.exe</Data>
<Data>5.0.512.1470</Data>
<Data>5ceae31d</Data>
<Data>byondcore.dll</Data>
<Data>5.0.512.1470</Data>
<Data>5ceae2aa</Data>
<Data>c0000005</Data>
<Data>0002ecb9</Data>
<Data>1a04</Data>
<Data>01d521c98ea6fe90</Data>
<Data>D:\Games\BYOND\bin\dreamseeker.exe</Data>
<Data>D:\Games\BYOND\bin\byondcore.dll</Data>
<Data>1d4b2b39-8dbd-11e9-82c8-408d5c1e6281</Data>
<Data>
</Data>
<Data>
</Data>
</EventData>
</Event>


Does the problem occur:
Every time? Or how often? No.
In other games? Unknown
In other user accounts? Yes
On other computers? Yes

When does the problem NOT occur?

Did the problem NOT occur in any earlier versions? If so, what was the last version that worked? (Visit http://www.byond.com/download/build to download old versions for testing.) Unknown, it was possibly created by increase in ANIMATION_PARALLEL animations during explosions. I'll be testing it more later, dumps can be provided if necessary.
Okay, I've done some tracing and it appears this is happening as the result of an animate() call. More specifically, it's the client responding to an animation message.

I've put a sanity check into the spot where it's crashing, though I haven't determined the cause down to the bare bones yet. I think I would need a test case to do so. However, I have a suspicion the sanity check will get the job done. I'm going to put that in for 1471 and ask if you can retest once that's out.
Will do. Thanks for the quick response!
Fix seems to be working, no crashes so far with the previous testing method.
Thanks. I'll add this to the release notes Monday if everything holds up.
Lummox JR resolved issue with message:
Animations could cause crashes in unusual circumstances.