Global regex does not update next search index

ID:2520089
 
Nov 2 2019, 9:53 am (Edited on Nov 2 2019, 10:12 am)
Resolved
Regression: The value of regex.next was not filled in correctly after a Find() on a global regex.
BYOND Version:513.1495
Operating System:Windows 10 Pro 64-bit
Web Browser:Firefox 70.0
Applies to:Dream Daemon
Status: Resolved (513.1496)
This issue has been resolved.
Descriptive Problem Summary:
Regex Find with global flag on does not update next search starting position.

Numbered Steps to Reproduce Problem:

Code Snippet (if applicable) to Reproduce Problem:
    var/example = "A A A A A A A"
    var/regex/R = new("A", "gm")
    var/count = 0
    while(R.Find(example))
        count++
    world << count


Expected Results:
7
Actual Results:
infinite loop
also happens with Find_char

When does the problem NOT occur?
Before 513.1493

Workarounds: Manually modify .next

Nov 2 2019, 10:24 am
Well that blows. Guess there's another update coming soon.
Nov 2 2019, 2:10 pm
When Dream Deamon loading map from old(stable) version DM, he couldn't load map and hangs.
On version 513.1491 all normal. When load update 1494 starts hugs.
Screenshot: https://i.imgur.com/4wK4Jgt.png
Last stable setting and build: https://github.com/AltHub-Team/Aurora-Station
Version and over compile info can search in .travis.yml

Nov 2 2019, 3:59 pm
In response to WolfETD
Probably regex related
Nov 2 2019, 7:25 pm
In response to WolfETD
Yep, this is likely a duplicate of id:2520089.
Nov 2 2019, 7:36 pm
Lummox JR resolved issue with message:
Regression: The value of regex.next was not filled in correctly after a Find() on a global regex.
Nov 3 2019, 5:44 am
In response to Lummox JR
No, Dream Deamon can't read map. All code not been edit, only update version from 513.1491 to 513.1494.
Nov 3 2019, 11:08 am
In response to WolfETD
Your screenshot says that's not the case. Actual DM code is running which means the map has already been loaded. You're seeing a problem in one of the SS13 subsystems related to the map, which is a totally different thing.
Nov 3 2019, 3:32 pm
In response to Lummox JR
Last. In it 2 minute GIF(https://i.imgur.com/RGE3Nma.gifv) i'm show what happens when run DM. DM hangs, not loging in DM, DM not show error or something, i can't connect to server. How i can see what procces when log hangs? I'm try reset byond, reinstall and etc. On over computer all normal...
Nov 3 2019, 7:40 pm
In response to WolfETD
Yes, Dream Daemon is hanging, but it's not on a map read. The output in Dream Daemon clearly shows actual code has been run, which happens only after the map read has been completed.

I think you should retest this once 513.1496 is available, because I strongly believe a global regex is at fault.
Nov 4 2019, 9:26 am
In response to WolfETD
513.1496 is up now, so please retest.
Nov 4 2019, 1:20 pm
In response to WolfETD
All works, at least at the initial check. Very thanks you, good luck, luck in all starts.