Right click verbs that go out of view and then back into views don't work

ID:2567342
 
May 2 2020, 8:46 pm
Resolved
The right-click menu fix caused a regression where some verbs were intermittently unavailable.
BYOND Version:513.1521
Operating System:Windows 10 Home 64-bit
Web Browser:Chrome 81.0.4044.129
Applies to:Dream Seeker
Status: Resolved (513.1522)
This issue has been resolved.
Descriptive Problem Summary:
Right click verbs that go out of view and then back into views don't work

Numbered Steps to Reproduce Problem:

Code Snippet (if applicable) to Reproduce Problem:


Expected Results:

Actual Results:

Does the problem occur:
Every time? Or how often?
In other games?
In other user accounts?
On other computers?

When does the problem NOT occur? 1520

Did the problem NOT occur in any earlier versions? If so, what was the last version that worked? (Visit http://www.byond.com/download/build to download old versions for testing.)

Workarounds:

May 3 2020, 7:50 am
Numbered Steps to Reproduce Problem:
Run the following code, use the give_verb_holder verb, then try to use the "Do Something" verb.
Code Snippet (if applicable) to Reproduce Problem:
/mob/verb/give_verb_holder()
    new /obj/verb_holder(src)

/obj/verb_holder/verb/do_thing()
    set name = "Do Something"

    world.log << "did something!"


Expected Results:
"did something" should be printed to the log.

Actual Results:
Nothing happens.

Does the problem occur:
Every time? Or how often? Every time.
In other games? Yes
In other user accounts? Didn't try
On other computers? Didn't try

Did the problem NOT occur in any earlier versions? If so, what was the last version that worked? I tested this on 513.1521 and it shows the buggy behavior. 512.1488 works fine.
May 3 2020, 9:44 am
In response to DamianQ
This is almost certainly a duplicate of id:2567342, but I would need a test case to tell. Also, in Beta Bugs you must always include the full build number in the report, not just "513".
May 3 2020, 9:45 am
Lummox JR resolved issue with message:
The right-click menu fix caused a regression where some verbs were intermittently unavailable.
May 3 2020, 10:39 am
In response to DamianQ
lol
May 3 2020, 7:05 pm
In response to DamianQ
Thanks for the edit. Please note I do need a test case because the nature of the other bug is rather intermittent. I don't think a snippet alone is enough to reliably reproduce verb issues.
May 3 2020, 7:16 pm
In response to DamianQ
I'm able to reproduce the issue 100% of the time by running that exact snippet.
Here is that exact same snippet wrapped in a brand new project that you can compile and run: https://github.com/DamianX/junk/raw/master/dungverbs.zip
May 3 2020, 7:25 pm
In response to DamianQ
That test case does not reproduce the issue for me. Ran in BYOND 513.1521 without any problems.
May 3 2020, 10:36 pm
In response to DamianQ
513.1522 seems to fix this issue. You can close this.