ID:2608654
 
Resolved
Setting map.icon-size no longer worked.
BYOND Version:513
Operating System:Windows 10 Home 64-bit
Web Browser:Chrome 84.0.4147.135
Applies to:Dream Seeker
Status: Resolved (513.1531)

This issue has been resolved.
Descriptive Problem Summary:

Calling icon-size on winset on Build 513.1530 no longer functions properly. On Build 513.1529 it would just crash the client and on Build 513.1528 it would work fine.

Numbered Steps to Reproduce Problem:

Run game, call a verb that sets icon-size, crash occurs.

Code Snippet (if applicable) to Reproduce Problem:
/client/proc/update_zoom(var/desired_zoom_level = 2)

if(!mob || !eye || eye != mob)
zoom_level = initial(zoom_level)
else
zoom_level = clamp(desired_zoom_level,MIN_ZOOM,MAX_ZOOM)

winset(src, "map.map","icon-size=[zoom_level*TILE_SIZE]")

return TRUE

/client/MouseWheel(object,delta_x,delta_y,location,control,params)

var/list/aug = params2list(params)

if(mob && (mob.attack_flags & ATTACK_GRAB) && allow_zoom_controls)
var/change_in_screen = delta_y > 1 ? 1 : -1
if(precise_zoom)
change_in_screen *= 0.1
update_zoom(zoom_level + change_in_screen)
return TRUE

mob.do_mouse_wheel(object,delta_x,delta_y,location,control,aug)

return TRUE


Expected Results:

It would successfully set the zoom level.

Actual Results:
Does nothing.

Does the problem occur:
Every time? Or how often? Every time.
In other games? Unknown.
In other user accounts? Yes.
On other computers? Yes.

When does the problem NOT occur?
Using an old version.

Did the problem NOT occur in any earlier versions? If so, what was the last version that worked? (Visit http://www.byond.com/download/build to download old versions for testing.)

Yes, on Build 513.1529 it would just crash the client and on Build 513.1528 it would work fine.

Workarounds:
Using "zoom" instead works, however it is laggier than using just icon-size in previous versions, at least.
BurgerBB wrote:
Workarounds:
Using "zoom" instead works, however it is laggier than using just icon-size in previous versions, at least.

It's not possible for zoom to be laggier. That's entirely in your imagination.

The zoom param is the correct one to be using, since icon-size is deprecated. Still, icon-size is supposed to work so I'm looking into the bug.
Lummox JR resolved issue with message:
Setting map.icon-size no longer worked.