New help with party xp share

ID:264986
 
Sep 11 2011, 3:48 am
Code:
Death(mob/M)
            if(src.Hp <= 0)
                Hp = 0
                if(!src.client)
                    if(istype(src,/monster/))
                        M.Rep += src.Rep
                        M.Rep += 1
                        src.loc=locate(199,2,1)
                        spawn(4000)
                            src.loc=locate(src.oldx,src.oldy,src.oldz)
                            src.Hp=src.MHp
                            src.overlays -= src.HealthOverlay
                        if(M.Quincy == 1)
                            M.BowEXP += round((src.Xp))
                        for(var/obj/Inv/Zanpaktou/O)
                            if(usr.Zan == 1)
                                O.WeaponExp += round((src.Xp))
                                O.WLevelUp()
                        if(M.in_party == 1)
                            for(var/mob/P in usr.party)
                                for(P in oview())
                                    if (P.party ==src.party)
                                        src.exp_members ++
                                if (src.Xpgained >0)
                                    src.Xpshare =src.Xpgained/src.exp_members
                                    for(P in oview())
                                        if (P.party ==src.party)
                                            P.Xp +=src.Xpshare
                                            P << output("You've gained[src.Xpshare] Xp.","info")
                                        src.Xpgained =0


                        else
                            M << output("<font color=#347C2C> You've gained Xp for killing [src].","info")
                            M.Xp += round((src.Xp))
                            M.Level_up()
                            M.UpDateB()


Problem description:

this code will not work for some reason need help to fix it
Sep 11 2011, 4:02 am
Can you please say what is wrong with it? It would be much easier to help that way.

for(var/mob/P in usr.party)
                                for(P in oview())


These lines make no sense.

It looks as though you have copied that entire piece of code from something separate then tried stitching it into that block.
Sep 11 2011, 4:50 am
In response to ANiChowy
it wont share Xp at all i just need a party share xp code
Sep 11 2011, 5:01 am
In response to The ComEdiAn
Sure thing.

party
  var/list/members = list()
  var/EXP
  var/method // Right now, a boolean value
  New(list/guys, method)
     members += guys
     src.method = method
  proc/gainEXP(num)
     EXP += num
     distribute()
  proc/distribute()
     if(!method) // Default action, equal distribution
        var/amount
        for(var/mob/A in members)
           amount = min(EXP, EXP / members.len)
           EXP -= amount
           A.gain_exp(amount)
        if(EXP < 0)
           EXP = 0
Sep 17 2011, 7:02 am
In response to ANiChowy
how would i implement this in my death check
Sep 17 2011, 1:58 pm
In response to The ComEdiAn
hint:

proc/gainEXP(num)