ID:2713514
 
Resolved
Animations on an image object or client, which send messages differently, were misbehaving in newer versions.
BYOND Version:514
Operating System:Windows 10 Home
Web Browser:Firefox 91.0
Applies to:Dream Seeker
Status: Resolved (514.1567)

This issue has been resolved.
Descriptive Problem Summary:
On 1566, an animate we used in SS13 has regressed to where it fades instantly. I am unsure if it is specific to 1566, and was not present in earlier beta builds.

I compiled a repro here: https://file.house/bZGK.zip

You can click on the brown box for some text to move up and fade out.

Code Snippet (if applicable) to Reproduce Problem:
#define BALLOON_TEXT_SPAWN_TIME 2
#define BALLOON_TEXT_FADE_TIME 1
#define BALLOON_TEXT_FULLY_VISIBLE_TIME 7
#define BALLOON_TEXT_TOTAL_LIFETIME (BALLOON_TEXT_SPAWN_TIME + BALLOON_TEXT_FULLY_VISIBLE_TIME + BALLOON_TEXT_FADE_TIME)
/// The increase in duration per character in seconds
#define BALLOON_TEXT_CHAR_LIFETIME_INCREASE_MULT (0.05)
/// The amount of characters needed before this increase takes into effect
#define BALLOON_TEXT_CHAR_LIFETIME_INCREASE_MIN 10

/obj/repro/Click()
var/image/balloon_alert = image(loc = src)
balloon_alert.alpha = 0
balloon_alert.maptext = "balloon!"
balloon_alert.maptext_width = 200
usr.client.images += balloon_alert

animate(
balloon_alert,
pixel_y = world.icon_size * 1.2,
time = BALLOON_TEXT_TOTAL_LIFETIME,
easing = SINE_EASING | EASE_OUT,
)

animate(
alpha = 255,
time = BALLOON_TEXT_SPAWN_TIME,
easing = CUBIC_EASING | EASE_OUT,
flags = ANIMATION_PARALLEL,
)

animate(
alpha = 0,
time = BALLOON_TEXT_FULLY_VISIBLE_TIME,
easing = CUBIC_EASING | EASE_IN,
)


Expected Results:
https://streamable.com/tegw7t

The text comes up and smoothly fades out.

Actual Results:
https://streamable.com/oerhij

The text comes up and immediately disappears.

This occurs every time on 1566.

Did the problem NOT occur in any earlier versions? If so, what was the last version that worked? (Visit http://www.byond.com/download/build to download old versions for testing.)
I have not tested on every BYOND version, but 1556 is what I use, and it works fine.
Good catch. I thought all the animate bugs were behind us but this is a straggler. I'll get it sorted out.
Lummox JR resolved issue with message:
Animations on an image object or client, which send messages differently, were misbehaving in newer versions.