ID:889528
 
BYOND Version:494
Operating System:Windows 7 Pro 64-bit
Web Browser:Firefox 14.0.1
Applies to:Dream Seeker
Status: Open

Issue hasn't been assigned a status value.
Descriptive Problem Summary:
There's a backwards compatibility issue with IainPeregrine's Casual Quest in BYOND version 494 or greater.

In 494, the game just seems to stall while starting up or joining.

In later versions (496.1144), it seems to crash instead.

496 DS joining 494 DD:
Problem signature:
Problem Event Name: APPCRASH
Application Name: dreamseeker.exe
Application Version: 4.0.496.1144
Application Timestamp: 5004a2c3
Fault Module Name: StackHash_0a9e
Fault Module Version: 0.0.0.0
Fault Module Timestamp: 00000000
Exception Code: c0000005
Exception Offset: 00000000
OS Version: 6.1.7601.2.1.0.256.48
Locale ID: 1033
Additional Information 1: 0a9e
Additional Information 2: 0a9e372d3b4ad19135b953a78882e789
Additional Information 3: 0a9e
Additional Information 4: 0a9e372d3b4ad19135b953a78882e789


496 DS joining 496 DD:
Problem signature:
Problem Event Name: APPCRASH
Application Name: dreamdaemon.exe
Application Version: 4.0.496.1144
Application Timestamp: 5004a2bd
Fault Module Name: StackHash_0a9e
Fault Module Version: 0.0.0.0
Fault Module Timestamp: 00000000
Exception Code: c0000005
Exception Offset: 00000000
OS Version: 6.1.7601.2.1.0.256.48
Locale ID: 1033
Additional Information 1: 0a9e
Additional Information 2: 0a9e372d3b4ad19135b953a78882e789
Additional Information 3: 0a9e
Additional Information 4: 0a9e372d3b4ad19135b953a78882e789


Numbered Steps to Reproduce Problem:
A) Download and run Casual Quest directly in 494 DS (DS Stalls)

or

B) Download and run Casual Quest directly in 496 DS (DS Crashes)

or

C) Download and run Casual Quest in 496 DD, and connect with a 496 DS (DD crashes)

or

D) Download and run Casual Quest in 493 DD, and connect with a 496 DS (DS Stalls)


Expected Results:
Casual Quest still works in current version (ie, is backwards-compatible)

Actual Results:
Casual Quest will stall or crash in 494+

Does the problem occur:
Every time? Or how often? Every time
In other games? Unknown
In other user accounts? On Administrator
On other computers? Yes

When does the problem NOT occur?
When using 493

Did the problem NOT occur in any earlier versions? If so, what was the last version that worked? (Visit http://www.byond.com/download/build to download old versions for testing.)
Downgrading to 493 seems to allow the game to run normally.

Workarounds:
Downgrade to 493.
There seem to be two components to this. The first is that he's doing something radically unsafe in client/New() by assuming the skin has already loaded--this changed in 494 and explains the problem. The second is that the "bad client" crash is messing up the stack, which is at our end. I'm trying to figure out where the problem is.
I uploaded a fix for CQ. You were right, moving the skin initialization out of client/New() immediately fixed the problem. If you need an older version of it that still causes the error, let me know.