get_dist() to return values over 127

ID:97991
 
Jul 3 2010, 2:27 pm
Applies to:DM Language
Status: Open
Issue hasn't been assigned a status value.
"At this time, get_dist() never returns a value greater than 127. " - the ref

As far as I know, get_dist is one of the few functions that is still limited to 127.
Seeing as things can be greater then 127 tiles away, I believe this procedure should be enhanced to allow the returning of a value greater than 127.
Jul 4 2010, 11:36 am
 
proc/GetDist(var/atom/A1,var/atom/A2)
    var/xDist
    if(A1.x>A2.x)   xDist=A1.x-A2.x
    else    xDist=A2.x-A1.x
    
    var/yDist
    if(A1.y>A2.y)   yDist=A1.y-A2.y
    else    yDist=A2.y-A1.y
    
    return max(xDist,yDist)
Jul 4 2010, 11:38 am
Why would I add something, when such a feature already exists in BYOND, but is limited?

Falacy wrote:
> proc/GetDist(var/atom/A1,var/atom/A2)
>   var/xDist
>   if(A1.x>A2.x)   xDist=A1.x-A2.x
>   else    xDist=A2.x-A1.x
>   
>   var/yDist
>   if(A1.y>A2.y)   yDist=A1.y-A2.y
>   else    yDist=A2.y-A1.y
>   
>   return max(xDist,yDist)
>

Jul 4 2010, 11:41 am (Edited on Jul 4 2010, 11:46 am)
Super Saiyan X wrote:
Why would I add something, when such a feature already exists in BYOND, but is limited?

Your question pretty much answers itself.
Jul 4 2010, 11:45 am (Edited on Jul 4 2010, 11:50 am)
Honestly, I don't even need use said function at the moment. I don't need a workaround if I don't need to use it. I'm just suggesting that get_dist be expanded to allow the returning of greater values. Srsly.
Jul 4 2010, 11:49 am
Something strange I just noticed o.O
If you get_dist() to the same object it returns -1, but if you get_dist() to different objects in the same place it returns 0.
Jul 14 2010, 6:36 am
Simpler:
proc/GetDist(var/atom/A1, var/atom/A2)
    return max(abs(A1.x-A2.x), abs(A1.y-A2.y))
Sep 8 2020, 12:39 pm
This came up in conversation so I'm going to bump this. Absolutely idiotic limit. The -1 returns are also weird and should be looked at.
Sep 8 2020, 12:55 pm
Shouldn't be any limit, we should be able to bring our project down in a glory of flames if we want to. Remove the limit or feel our silent wrath.
Sep 8 2020, 7:58 pm
Workarounds are not the solution though, because they're worse in performance than get_dist(). Maybe we should really get the enhancement
Sep 8 2020, 10:48 pm
In response to Vallat
Vallat wrote:
Workarounds are not the solution though, because they're worse in performance than get_dist(). Maybe we should really get the enhancement

Just to pile on, the manual workaround is 10x slower than get_dist(). Half of that is just the proc invocation overhead. If you drop that into a macro, it's unsafe and only 5x slower.
Jan 21 2021, 4:14 pm
bumping this, would be great for 514
Jan 30 2021, 12:48 am
+1

Really weird that this is still a thing