ID:139857
 
Code:
mob/creating_character
base_save_allowed = 0 // If player quits before choosing, don't want to save this mob

Login()
spawn()
src.CreateCharacter()
proc
CreateCharacter()
var
prompt_title = "New Character"
help_text = "What do you want to name the character?"
default_value = key
char_name = input(src, help_text, prompt_title, default_value) as null|text
list/classes
if (!char_name) //guess they don't want to create a new character after all, so send them to choose a character
client.base_ChooseCharacter()
return

var
ckey_name = ckey(char_name)
list
character = client.base_CharacterNames()
if (character.Find(ckey_name))
alert("You already have a character named that! Please choose another name.")
src.CreateCharacter()
return
classes = list("Alliance","Horde")
help_text = "Which class would you like to be?"
var/char_class = input(src, help_text, prompt_title) in classes
var
mob
new_mob
switch(char_class)
if("Alliance") new_mob = new /mob/Alliance()
if("Horde") new_mob = new /mob/Horde()
new_mob.name = char_name
src.client.mob = new_mob
usr.preslocation = "town"
// new_mob.density = 0
// new_mob.Move(first_location)
// new_mob.density = 1
del(src)

mob
Login()
if(usr.old == 0)
usr.old = 1
if(Side == "Alliance")
var/Race = input("What race would you like to be??") in list("Draenei","Dwarf","Gnome","Human","NightElf")
if(Race == "Draenei")
usr.Race = "Draenei"
var/class = input("What class would you like to be??") in list("Hunter","Mage","Paladin","Priest","Shaman","Warrior")
if(class == "Hunter")
usr.Class = "Hunter"
usr.Str = 21
usr.Agl = 20
usr.Sta = 21
usr.Int = 20
usr.Spr = 23
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Mage")
usr.Class = "Mage"
usr.Str = 21
usr.Agl = 17
usr.Sta = 20
usr.Int = 23
usr.Spr = 24
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Paladin")
usr.Class = "Paladin"
usr.Str = 23
usr.Agl = 17
usr.Sta = 22
usr.Int = 20
usr.Spr = 23
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Priest")
usr.Class = "Priest"
usr.Str = 21
usr.Agl = 17
usr.Sta = 20
usr.Int = 22
usr.Spr = 25
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Shaman")
usr.Class = "Shaman"
usr.Str = 22
usr.Agl = 17
usr.Sta = 21
usr.Int = 21
usr.Spr = 24
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Warrior")
usr.Class = "Warrior"
usr.Str = 24
usr.Agl = 17
usr.Sta = 22
usr.Int = 20
usr.Spr = 22
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(Race == "Dwarf")
var/class = input("What class would you like to be??") in list("Hunter","Paladin","Priest","Rogue","Warrior")
if(class == "Hunter")
usr.Class = "Hunter"
usr.Str = 25
usr.Agl = 19
usr.Sta = 22
usr.Int = 19
usr.Spr = 20
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Paladin")
usr.Class = "Paladin"
usr.Str = 27
usr.Agl = 16
usr.Sta = 23
usr.Int = 19
usr.Spr = 20
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Priest")
usr.Class = "Priest"
usr.Str = 25
usr.Agl = 16
usr.Sta = 21
usr.Int = 21
usr.Spr = 22
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Rogue")
usr.Class = "Rogue"
usr.Str = 26
usr.Agl = 19
usr.Sta = 22
usr.Int = 19
usr.Spr = 19
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Warrior")
usr.Class = "Warrior"
usr.Str = 28
usr.Agl = 16
usr.Sta = 23
usr.Int = 19
usr.Spr = 19
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(Race == "Gnome")
usr.Race = "Gnome"
var/class = input("What class would you like to be??") in list("Mage","Rogue","Warlock","Warrior")
if(class == "Mage")
usr.Class = "Mage"
usr.Str = 15
usr.Agl = 22
usr.Sta = 20
usr.Int = 27
usr.Spr = 22
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Rogue")
usr.Class = "Rogue"
usr.Str = 16
usr.Agl = 25
usr.Sta = 21
usr.Int = 24
usr.Spr = 20
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Warlock")
usr.Class = "Warlock"
usr.Str = 15
usr.Agl = 22
usr.Sta = 21
usr.Int = 26
usr.Spr = 22
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Warrior")
usr.Class = "Warrior"
usr.Str = 18
usr.Agl = 22
usr.Sta = 22
usr.Int = 24
usr.Spr = 20
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(Race == "Human")
usr.Race = "Human"
var/class = input("What class would you like to be??") in list("Mage","Paladin","Priest","Rogue","Warlock","Warrior")
if(class == "Mage")
usr.Class = "Mage"
usr.Str = 20
usr.Agl = 20
usr.Sta = 20
usr.Int = 23
usr.Spr = 22
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Paladin")
usr.Class = "Paladin"
usr.Str = 22
usr.Agl = 20
usr.Sta = 22
usr.Int = 20
usr.Spr = 21
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Priest")
usr.Class = "Priest"
usr.Str = 20
usr.Agl = 20
usr.Sta = 20
usr.Int = 22
usr.Spr = 23
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Rogue")
usr.Class = "Rogue"
usr.Str = 21
usr.Agl = 23
usr.Sta = 21
usr.Int = 20
usr.Spr = 20
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Warlock")
usr.Class = "Warlock"
usr.Str = 20
usr.Agl = 20
usr.Sta = 21
usr.Int = 22
usr.Spr = 22
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Warrior")
usr.Class = "Warrior"
usr.Str = 23
usr.Agl = 20
usr.Sta = 20
usr.Int = 20
usr.Spr = 20
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(Race == "NightElf")
usr.Race = "NightElf"
var/class = input("What class would you like to be??") in list("Druid","Hunter","Priest","Rogue","Warrior")
if(class == "Druid")
usr.Class = "Druid"
usr.Str = 17
usr.Agl = 24
usr.Sta = 20
usr.Int = 22
usr.Spr = 22
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Hunter")
usr.Class = "Hunter"
usr.Str = 16
usr.Agl = 27
usr.Sta = 21
usr.Int = 20
usr.Spr = 21
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Priest")
usr.Class = "Priest"
usr.Str = 16
usr.Agl = 24
usr.Sta = 20
usr.Int = 22
usr.Spr = 23
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Rogue")
usr.Class = "Rogue"
usr.Str = 17
usr.Agl = 27
usr.Sta = 21
usr.Int = 20
usr.Spr = 20
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Warrior")
usr.Class = "Warrior"
usr.Str = 19
usr.Agl = 24
usr.Sta = 22
usr.Int = 20
usr.Spr = 20
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"


if (usr.Side == "Horde")
var/race = input("What race would you like to be??") in list("BloodElf","Orc","Tauren","Troll","Undead")
if(race == "BloodElf")
usr.Race = "BloodElf"
var/class = input("What class would you like to be??") in list("Hunter","Mage","Priest","Rogue","Warrior")
if(class == "Hunter")
usr.Class = "Hunter"
usr.Str = 17
usr.Agl = 25
usr.Sta = 21
usr.Int = 23
usr.Spr = 19
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Mage")
usr.Class = "Mage"
usr.Str = 17
usr.Agl = 22
usr.Sta = 20
usr.Int = 26
usr.Spr = 20
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Paladin")
usr.Class = "Paladin"
usr.Str = 19
usr.Agl = 22
usr.Sta = 22
usr.Int = 23
usr.Spr = 19
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Priest")
usr.Class = "Priest"
usr.Str = 17
usr.Agl = 22
usr.Sta = 20
usr.Int = 25
usr.Spr = 21
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Rogue")
usr.Class = "Rogue"
usr.Str = 18
usr.Agl = 25
usr.Sta = 21
usr.Int = 23
usr.Spr = 18
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Warlock")
usr.Class = "Warlock"
usr.Str = 17
usr.Agl = 22
usr.Sta = 21
usr.Int = 25
usr.Spr = 20
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(race == "Orc")
usr.Race = "Orc"
var/class = input("What class would you like to be??") in list("Hunter","Rogue","Shaman","Warlock","Warrior")
if(class == "Hunter")
usr.Class = "Hunter"
usr.Str = 23
usr.Agl = 20
usr.Sta = 22
usr.Int = 17
usr.Spr = 23
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Rogue")
usr.Class = "Rogue"
usr.Str = 24
usr.Agl = 25
usr.Sta = 21
usr.Int = 16
usr.Spr = 21
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Shaman")
usr.Class = "Shaman"
usr.Str = 24
usr.Agl = 17
usr.Sta = 22
usr.Int = 18
usr.Spr = 24
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Warlock")
usr.Class = "Warlock"
usr.Str = 23
usr.Agl = 22
usr.Sta = 22
usr.Int = 18
usr.Spr = 23
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Warrior")
usr.Class = "Warrior"
usr.Str = 26
usr.Agl = 17
usr.Sta = 23
usr.Int = 17
usr.Spr = 22
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(race == "Tauren")
usr.Race = "Tauren"
var/class = input("What class would you like to be??") in list("Druid","Hunter","Shaman","Warrior")
if(class == "Druid")
usr.Class = "Druid"
usr.Str = 26
usr.Agl = 16
usr.Sta = 21
usr.Int = 18
usr.Spr = 24
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Hunter")
usr.Class = "Hunter"
usr.Str = 25
usr.Agl = 19
usr.Sta = 22
usr.Int = 16
usr.Spr = 23
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Shaman")
usr.Class = "Shaman"
usr.Str = 26
usr.Agl = 16
usr.Sta = 22
usr.Int = 17
usr.Spr = 24
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Warrior")
usr.Class = "Warrior"
usr.Str = 28
usr.Agl = 16
usr.Sta = 23
usr.Int = 16
usr.Spr = 22
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(race == "Troll")
usr.Race = "Troll"
var/class = input("What class would you like to be??") in list("Hunter","Mage","Priest","Rogue","Shaman","Warrior")
if(class == "Hunter")
usr.Class = "Hunter"
usr.Str = 21
usr.Agl = 25
usr.Sta = 21
usr.Int = 16
usr.Spr = 22
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Mage")
usr.Class = "Mage"
usr.Str = 21
usr.Agl = 22
usr.Sta = 20
usr.Int = 19
usr.Spr = 23
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Priest")
usr.Str = 21
usr.Agl = 22
usr.Sta = 20
usr.Int = 18
usr.Spr = 24
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Rogue")
usr.Class = "Rogue"
usr.Str = 22
usr.Agl = 25
usr.Sta = 21
usr.Int = 16
usr.Spr = 21
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Shaman")
usr.Class = "Shaman"
usr.Str = 22
usr.Agl = 22
usr.Sta = 21
usr.Int = 17
usr.Spr = 23
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Warrior")
usr.Class = "Warrior"
usr.Str = 24
usr.Agl = 22
usr.Sta = 22
usr.Int = 16
usr.Spr = 21
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(race == "Undead")
usr.Race = "Undead"
var/class = input("What class would you like to be??") in list("Mage","Priest","Rogue","Warlock","Warrior")
if(class == "Mage")
usr.Class = "Mage"
usr.Str = 19
usr.Agl = 18
usr.Sta = 20
usr.Int = 21
usr.Spr = 27
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Priest")
usr.Class = "Priest"
usr.Str = 19
usr.Agl = 18
usr.Sta = 20
usr.Int = 20
usr.Spr = 28
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Rogue")
usr.Class = "Rogue"
usr.Str = 20
usr.Agl = 21
usr.Sta = 21
usr.Int = 18
usr.Spr = 25
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Warlock")
usr.Class = "Warlock"
usr.Str = 19
usr.Agl = 18
usr.Sta = 21
usr.Int = 20
usr.Spr = 27
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"
if(class == "Warrior")
usr.Class = "Warrior"
usr.Str = 22
usr.Agl = 18
usr.Sta = 22
usr.Int = 18
usr.Spr = 25
var/Gender = input("What gender would you like to be??") in list("Male","Female")
if(Gender == "Male")
usr.gender = "Male"
if(Gender == "Female")
usr.gender = "Female"


usr.Level = 1
usr.Exp = 0
usr.MaxExp = 400
usr.MDamage = round(usr.Str/7)
usr.MaxHP = usr.Sta * 4
usr.MaxMP = usr.Int * 4
usr.HP = usr.MaxHP
usr.MP = usr.MaxMP
usr.Armor = usr.Agl * 2
usr.Gold = 0
usr.Silver = 0
usr.Copper = 0

// src.contents += new /obj/Armor/Cloth/PrimalMoonclothRobe
// src.contents += new /obj/Armor/Leather/VindicatorsLightVest
// src.contents += new /obj/Armor/Mail/KhansChestpiece
// src.contents += new /obj/Weapons/Staves/DignifiedHeadmastersCharge

usr.onbattlefield="0"
usr.preslocation = "town"
var/turf/first_location
var/townchoice = input("Where would you like to start?") in list("Ryuzak","Shelville")
usr.density = 0
if (townchoice == "Ryuzak")
first_location = locate(17,37,2)
usr.savex = 17
usr.savey = 37
usr.savez = 2
else
first_location = locate(196,81,2)
usr.savex = 196
usr.savey = 81
usr.savez = 2
usr.Move(first_location)
usr.turntog = 0
.=..()
usr.density = 1


Problem description:
I tested this on a different game and it worked.
I took the code changed only the needed info and now it doesn't work. Every time I log in even to a already created character it's as if its a brand new character.
Now you only get to pick what side you want to be on and nothing else.
If you took the working code, and changed it, maybe that is what causes the problem? Have you changed vital parts of the code?

Anyways.. I'm no genious. But, if you log in and get handeled as if it's the first time every time. It's because your calling the src.CreateCharacter()regardless upon Login(), which it looks as if it's what you might be doing.

That being said, you might have some other code that is supposed to prevent that?, if not, this is most likely what you should have.








as the other poster said.

your calling the procedures relating to creation every time you log in.

Set some mob vars.

possibly make a new mob to handle char creation specifically and voolah.

Either way. you repeat the login step every time you login so yea new char each time.. well not really but new char stats all the time
* Don't use USR in a PROC. Instead use something like var/mob/M, and call a variable as such:
mob/proc/whatever()
var/mob/M
var/HP = 5
M.HP--

* Why do you have the spawn() there? It seems like you would be using a lot more memory than you need to.

* It saves more space to make an atom's location null instead of deleting it.

When you are doing something such as setting stats, I think that you could make this much neater in ways.

Ex.
if(Class == "One")
str = 10
con = 10
agi = 10
if(Class == "Two"
str = 13
con = 8
agi = 9


You could have variables which hold the preset values in a list as such:
var/list/Classes[2][3] // This is a multi-dimensional list which is basically two lists, and each list has 3 "spaces" in it

world/New()
Classes[1][1] = 10
Classes[1][2] = 10
Classes[1][3] = 10

Classes[2][1] = 13
Classes[2][2] = 8
Classes[2][3] = 9
..()

mob/verb/Class()
var/setup
input("Select a class.", "Your Gender", class) in list("One","Two"))//I dont know if i wrote this input statement correctly

if("One")
setup = 1
if("Two")
setup = 2

str = Classes[setup][1]
con = Classes[setup][2]
agi = Classes[setup][3]


Note: I am not sure if my indentation is correct because I have not compiled this, but you should be able to understand how you can work this better. I believe this should be more efficient because you already have the values set up and stored to reference when creating the character.
In response to Darkjohn66 (#3)
Its from a game source so why some of the stuff is there IDK
In response to Dorky106 (#4)
Read my other post again, I was working on it and edited it. Also, if you are using a game source, do you think you will ever learn anything that would allow you to do something cool/high-level? I doubt it.
Hello there,

Now, the way i see it, is that you have the Login() for character creation and the Login() for the race and so forth. You've split them (which isn't bad) but in a wierd way..

Also, I would not do all that stuff under mob/Login(). make a proc and call it upon Login() just as with the src.Charcreation(), or in this case you would want to call it after choosing your alliance.


I would suggest to redo the whole character creation.
Keep in mind: "Easy can be better", you don't need to make it more complicated than it is. In your case this is something someone else made, but anyways. Make a new, use the one you took from the other source as a loose reference if you want to, It's not what i would call great though.

mob
Login()
spawn() src.Check()
..()

mob
proc
Check()
if(hassave)
src.Load()
else
src.CreateChar()

CreateChar()
var/Name = input("Name") as text
src.name = Name
switch(input("Alliance") in list("Horde","Alliance"))
if("Alliance")
src.alliance = "Alliance"
src.Class()
return

Class()
if(src.alliance == "Alliance")
//do the class stuff