Luan12's Site - Save unsaving?

Save unsaving? in Developer Help

Page: 1 2

ID:318940

Feb 19 2012, 9:58 pm

(See the best response by Neimo.)

Luan12

Code:

mob/verb
    Save()
        set hidden = 1
        if(usr.telalogin==0)
            var/savefile/F = new("players/[src.key].sav")
            F["last_x"] << x
            F["last_y"] << y
            F["last_z"] << z
            src.X = src.verbs
            Write(F)
            src << "<small><font color=red><b>Saved!"

        else
            usr<<"You <b>can't</b>  save here"
            return

mob
    proc
        Load()
            if(fexists("players/[src.key].sav"))
                var/savefile/F= new("players/[src.key].sav")
                F["last_x"] >> x
                F["last_y"] >> y
                F["last_z"] >> z
                Read(F)

Problem description:
So, sometimes, when I log in the server, my save have just "gone", and I log like this:
Luan12(Luan12) have logged in the server.
then my verbs, my char, everything is just GONE

#1 Feb 20 2012, 1:58 am
Tafe	the problem describtion didn't give me much information though.

#2 Feb 20 2012, 5:14 am
Luan12	Ok, you have the save right? YOur character, your verbs, your vars saved... BUT, sometimes in the server, I don't know why god in a beautifull morning you enter in the server and: PÁ, you lose your save! And in the server, when you enter appears this: YourKey(YourKey) has logged in the server instead YourName(YourKey) has logged in the server, you know?

#3 Feb 20 2012, 8:08 am

Neimo

First off, you should not be calling Read() and Write() directly, and you are saving incorrectly.

client
  proc
    Save()
      var/savefile/F = new("[ckey].sav")
      F["mob"] << mob
      // Do not add anything more to be saved here
    Load()
      if(fexists("[ckey].sav"))
        var/savefile/F = new("[ckey].sav")
        F["mob"] >> mob
        // Do not add anything more to be loaded here

mob
  Write(var/savefile/F)
    ..()
    // Add any special processing for saving here
    F["x"] << x
    F["y"] << y
    F["z"] << z
  Read(var/savefile/F)
    ..()
    // Add any special processing for loading here
    loc = locate(F["x"], F["y"], F["z"])

#4 Feb 20 2012, 8:48 am

Lummox JR

You can't use F["x"] and such directly. Those need to be loaded into local vars before you use them in locate().

mob/Read(savefile/F)
    var X,Y,Z
    ..()
    F["x"] >> X
    F["y"] >> Y
    F["z"] >> Z
    loc = locate(X, Y, Z)

Otherwise though you're quite correct, it's a bad idea to call Read() or Write() directly.

#5 Feb 20 2012, 8:53 am In response to Lummox JR (#4)
Kaiochao	Why does it work if you're not supposed to?

#6 Feb 20 2012, 8:54 am In response to Lummox JR (#4)
Neimo	What's wrong with using `F["X"], F["Y"], and F["Z"]` directly as it pulls the data from the savefile? I would assume it's better than creating 3 new variables to load what could be done directly.

#7 Feb 20 2012, 9:31 am In response to Neimo (#3)
Luan12	Which proc I call to save and load? To Save -> only Save or Save and write? like this: usr.Write() usr.client.Save() To Load -> only Load or Read too? like this: usr.Read() usr.client.Load()

#8 Feb 20 2012, 10:42 am

Neimo

Do not call them at all (Read()/Write()), they call themselves automatically.

usr.client.Save() // for saving
usr.client.Load() // for loading

#9 Feb 20 2012, 11:43 am In response to Neimo (#8)
Luan12	With your SAVE System, i create the char, when I relog appears the same bug... You're in the first screen of the server, your name and your status are just gone...

#10 Feb 20 2012, 12:06 pm In response to Neimo (#6)
Lummox JR	Neimo wrote: What's wrong with using `F["X"], F["Y"], and F["Z"]` directly as it pulls the data from the savefile? I would assume it's better than creating 3 new variables to load what could be done directly. Unless I'm way out of date on this, it can't be done directly; a savefile does not actually work like an associative list, and needs the << and >> operators to function correctly.

#11 Feb 20 2012, 12:07 pm In response to Lummox JR (#10)
Luan12	only the read is wrong?

#12 Feb 20 2012, 12:18 pm
Lummox JR	Well what Neimo was saying was that you shouldn't be calling Read() and Write() directly, with which I agree; you should do the location saving/loading inside those routines. The only correction I had was that the way he implemented the Read() won't work. You need to load the x,y,z coords into local vars and then use locate().

#13 Feb 20 2012, 12:36 pm

In response to Lummox JR (#10)

Neimo

You must be out of date then, you can check for yourself; receiving data directly doing F["x"] is possible.

Luan12 wrote:

With your SAVE System, i create the char, when I relog appears the same bug...

You're in the first screen of the server, your name and your status are just gone...

Have you tried using client/New() and client/Del() for saving and loading? Are you logging in twice? Does it actually create the savefiles?

#14 Feb 20 2012, 12:38 pm
Luan12	Yes, I recreated the char. NO, i'm not loggin in twice

#15 Feb 20 2012, 12:41 pm In response to Luan12 (#14)
Neimo	Yes to what? Show everything that you have dealing with your saving/loading system.

#16 Feb 20 2012, 1:00 pm (Edited on Feb 20 2012, 1:38 pm)

Luan12

I recreated it. Ok, i'll show:

client
    proc
        Save()
            var/savefile/F = new("players/[ckey].sav")
            F["mob"] << mob
            // Do not add anything more to be saved here
        Load()
            if(fexists("player/[ckey].sav"))
                var/savefile/F = new("players/[ckey].sav")
                F["mob"] >> mob
                // Do not add anything more to be loaded here

mob
    Write(var/savefile/F)
        ..()
        // Add any special processing for saving here
        F["x"] << x
        F["y"] << y
        F["z"] << z
        src.X = src.verbs
    Read(var/savefile/F)
        ..()
        // Add any special processing for loading here
        loc = locate(F["x"], F["y"], F["z"])
        src.verbs = src.X
        world<<"Deu certo"

mob/Logout()
    src.client.Save()
    del src
mob/proc/Choice()
    switch(alert("O que você quer fazer?","Char","Criar","Log In","Deletar"))
        if("Criar")
            src.create()
        if("Log In")
            if(fexists("players/[src.key].sav"))
                src.client.Load()

#17 Feb 22 2012, 3:16 pm

Best response

Neimo

I hope you still aren't having any problems and that you can read English pretty well. (from your game's language)

world
    mob = /mob/player // path for real mobs

mob/var/tmp/active = 0

mob/Read(var/savefile/f)
    ..()
    loc = locate(f["x"], f["y"], f["z"])
    world << "[src] has logged back in."
    active = 1 // now you will be able to activate auto-saving

mob/Write(var/savefile/f)
    ..()
    f["x"] << x
    f["y"] << y
    f["z"] << z
    f.dir.Remove("icon", "verbs", "contents", "overlays", "underlays")
    // it is ideal to remove all unnecessary data in savefiles that can be reloaded & created
    // all icon data and /mob/var/icon variables should be removed from saving

mob/player
    Login()
        loc = locate(/turf/places/titlescreen) // self explanitory

    Logout()
        del(src)

client/New()
    world << "[src] has logged in!"
    chooseoption() // call the action to new/load/delete a game
    ..()

client/Del()
    if(mob && mob.active) // if your mob isn't null & you're logged in
        savecharacter() // save your character (auto-saving)

    world << "[src] has logged out!"
    ..()

client/proc
    chooseoption(var/option)
        do
            option = input(src, "Description", "Title") in list ("New", "Load", "Delete")
        while(!validoption(option)) // while you cannot choose the option, keep doing it
        switch(option)
            if("New")
                newcharacter()
                src << "You have started a new game."
            if("Load")
                loadcharacter()
                src << "You have loaded your game."
            if("Delete")
                fdel("path/[ckey].sav")
                src << "You have deleted your game."

    loadcharacter()
        var/savefile/f = new("path/[ckey].sav")
        f["mob"] >> mob

    newcharacter()
    //  all things pertaining to your new character/game, i don't know it

    savecharacter()
        var/savefile/f = new("path/[ckey].sav")
        f["mob"] << mob

    validoption(option)
        switch(option)
            if("New")
                if(fexists("path/[ckey].sav"))
                    src << "You already have a game saved."
                    return 0
            if("Load")
                if(!fexists("path/[ckey].sav"))
                    src << "You don't have a character to load."
                    return 0
            if("Delete")
                if(!fexists("path/[ckey].sav"))
                    src << "You don't have a character to delete."
                    return 0
        return 1

I just wrote this and did not test anything -- I compile tested -- so if any bugs report let me know.

#18 Feb 23 2012, 8:55 am
Lummox JR	Another way to go, as a nicer option, is you can look at whether the file exists before presenting the new/load/delete options, and hiding or disabling those that don't apply.

#19 Feb 23 2012, 5:09 pm In response to Neimo (#17)
Luan12	Hey man, I put your system, and it happened: Luan12 has logged off Luan has logged back in. So, my view was wrong, my verbs desapeared, and my player was invisible, also I couldn't move.

Page: 1 2