Who command in Developer Help

ID:150000
 
Jan 9 2002, 3:51 pm
who()
set desc = "Check to see who is online"
set category = "Comm."
var/mob/M
usr << "***| The Trinity Star |***"
for(M in world)
if(M.key) usr << "([M.level] [M.classmin][M.pkillwho]) [M.afkwho][M.name] [M.title]"

I was wondering how I could make this sort by character level?
#1 Jan 9 2002, 4:07 pm
after if(M.key) put under it indented if(M.level=2)
whatever? Is that what you mean?
#2 Jan 9 2002, 4:11 pm
In response to Air _King (#1)
Air_King's a good coder i think you should do what he says it sound's like a good idea
#3 Jan 9 2002, 4:13 pm
Polatrite wrote:
who()
set desc = "Check to see who is online"
set category = "Comm."
var/mob/M
usr << "***| The Trinity Star |***"
for(M in world)
if(M.key) usr << "([M.level] [M.classmin][M.pkillwho]) [M.afkwho][M.name] [M.title]"

I was wondering how I could make this sort by character level?

You might check my List library for sorting routines...I should make a demo for that soon:

byond://Deadron.List
#4 Jan 9 2002, 4:42 pm
In response to SSJ4_Gohan_Majin (#2)
SSJ4_Gohan_Majin wrote:
Air_King's a good coder i think you should do what he says it sound's like a good idea\

Didn't sound to me like he understood the question at all. Did you?
#5 Jan 9 2002, 4:51 pm
In response to Deadron (#3)
I looked over the list thing, but my who command doesn't have a list, could you show me the correct way to use the dd_sortedObjectList() proc, in conjunction with my who command?
#6 Jan 9 2002, 5:17 pm
In response to Polatrite (#5)
When you do your for() loop, just add everything it finds to a list.

var/list/Players = list()
for(var/mob/M in world)
if(M.client)
Players += M

Then sort Players however you want.
#7 Jan 9 2002, 6:02 pm
In response to SSJ4_Gohan_Majin (#2)
SSJ4_Gohan_Majin wrote:
Air_King's a good coder i think you should do what he says it sound's like a good idea
Thank you for the compliment, but i didn't fullt understand what he meant by "I was wondering how I could make this sort by character level?" I think, hmmm sort sort the users in the world with their vars = a level? What level explain in detail next time.
#8 Jan 10 2002, 10:45 am
Still having problems, this is my new who code.
who()
set desc = "Check to see who is online"
set category = "Comm."
var/mob/M
usr << "***| The Trinity Star |***"
var/list/Players = list()
for(M in world)
if(M.client)
M.level += Players
dd_sortedObjectList(Players)
for(var/mob/P in Players)
usr << "([P.level] [P.classmin][P.pkillwho]) [P.afkwho][P.name] [P.title]"

Using Deadron's list library for the dd_sorted proc, but I get this readout, runtime error...
runtime error: type mismatch
proc name: who (/mob/pc/verb/who)
usr: Polatrite (/mob/pc/warrior)
src: Polatrite (/mob/pc/warrior)
call stack:
Polatrite (/mob/pc/warrior): who()

Maybe if the error was more specific I could figure it out, but alas, maybe I am just stupid.
#9 Jan 10 2002, 11:15 am
In response to Polatrite (#8)
It probably won't solve all your troubles, but you do need to set the line
M.level += Players

to be

Players += M.level
#10 Jan 10 2002, 12:47 pm
In response to Skysaw (#9)
Skysaw wrote:
It probably won't solve all your troubles, but you do need to set the line
M.level += Players

to be

Players += M.level

M.level is probably not a player, so the code isn't going to do much when he then loops through mobs in the Players list.

To use the sorted list from my object, you need to specify what to sort on in the dd_SortValue() function. Since you're sorting mobs, add this:

mob
    dd_SortValue()
        return level


Then in your who() verb do this:

var/list/Players = new()
for (var/mob/M in world)
    if (M.client)
        Players += M

Players = dd_sortedObjectList(Players)
...


You could make this whole thing simpler and more efficient by including my Players library, which tracks players for you.

byond://Deadron.Players

Then the who() code would look like:

var/list/Players = dd_sortedObjectList(base_PlayerMobs())
#11 Jan 10 2002, 12:53 pm
In response to Deadron (#10)
Deadron wrote:
Skysaw wrote:
It probably won't solve all your troubles, but you do need to set the line
M.level += Players

to be

Players += M.level

M.level is probably not a player, so the code isn't going to do much when he then loops through mobs in the Players list.

Thanks, I didn't want to get into all of that, which is why I just warned that it wasn't going to solve the troubles. My main point was that M.level certainly wasn't a list.