Errors in Developer Help

ID:264693
 
Apr 1 2010, 3:30 pm
Code:
character create.dm

turf
    join
        name = "Login"
        icon = 'Join.GIF'
        layer = 2
        density = 0
        opacity = 1
        Click()
            if(usr.character==0)
                var/name = input("","Character Name") as text|null
                usr.name="[html_encode(name)]"

                switch(input("Are you male or female?", "Gender") in list ("Male", "Female"))
                    if ("Male")
                        usr.cgender = "Male"
                        usr.icon = 'maleL.dmi'
                        usr.character = 1
                        usr.verbs+=typesof (/mob/player/verb/)
                        usr.loc = locate(1, 1, 2)
                    if ("Female")
                        usr.cgender = "Female"
                        usr.icon = 'femaleL.dmi'
                        usr.character = 1
                        usr.verbs+=typesof (/mob/player/verb/)
                        usr.loc = locate(1, 1, 2)
            if(fexists("players/[usr.client.ckey].sav"))
                var/savefile/F = new("players/[src.key].sav")
                Read(F)


Problem description: Some minor errors I need fixed. Help please.

character create.dm:27:error: src.key: undefined var

#1 Apr 1 2010, 3:35 pm
look in autosave dm...

you made if a proc

mob
    proc
        if(src.character==1)


should be

mob
    proc
        Auto_Save()//or whatever you want to call it...
            if(src.character==1)
#2 Apr 1 2010, 3:37 pm
once again lol...

change

            if(fexists("players/[usr.client.ckey].sav"))
                var/savefile/F = new("players/[src.key].sav")
                Read(F)


to

            if(fexists("players/[usr.client.ckey].sav"))
                var/savefile/F = new("players/[usr.key].sav")
                Read(F)


it thinks src is the turf :P
#3 Apr 1 2010, 3:40 pm
Ryu-Kazuki wrote:
Code:
> character create.dm
> 
> turf
>   join
>       name = "Login"
>       icon = 'Join.GIF'
>       layer = 2
>       density = 0
>       opacity = 1
>       Click()
>           if(usr.character==0)
>               var/name = input("","Character Name") as text|null
>               usr.name="[html_encode(name)]"
> 
>               switch(input("Are you male or female?", "Gender") in list ("Male", "Female"))
>                   if ("Male")
>                       usr.cgender = "Male"
>                       usr.icon = 'maleL.dmi'
>                       usr.character = 1
>                       usr.verbs+=typesof (/mob/player/verb/)
>                       usr.loc = locate(1, 1, 2)
>                   if ("Female")
>                       usr.cgender = "Female"
>                       usr.icon = 'femaleL.dmi'
>                       usr.character = 1
>                       usr.verbs+=typesof (/mob/player/verb/)
>                       usr.loc = locate(1, 1, 2)
>           if(fexists("players/[usr.client.ckey].sav"))
>               var/savefile/F = new("players/[src.key].sav")
>               Read(F)
>


Problem description: Some minor errors I need fixed. Help please.

character create.dm:27:error: src.key: undefined var

Replace src.key with usr.key
#4 Apr 1 2010, 3:51 pm
Calling Read() and Write() is the wrong way to save and load, and can lead to corrupted savefiles. To properly save/load, use the << and >> operators, like so:

turf/join/Click()
  var/savefile/F = new("[usr.ckey].sav")
  var/mob/oldmob = usr
  // Create a new mob from the savefile
  var/mob/newmob
  F["mob"] >> newmob
  // Delete the old mob
  del(oldmob)

// Save on player quitting:
client/Del()
  var/savefile/F = new("[ckey].sav")
  F["mob"] << mob