No Topic in Developer Help

ID:142015
 
Sep 11 2008, 5:06 pm
Code:
mob
 turret
  name = "Turret"
  icon = 'turret.dmi'
  New()
   serp
    icon_state = ""
    src.health = 100
    src.isplayer = 0
    src.race = "Turret"
    density = 1
    src.turretisauto = 0
    src.frozen = 1
    for(var/mob/M in oview(12))
        if(istype(M,/mob/zombie/))
            if(src.turretisauto == 0)
                src.icon_state = "attack"
                oview(12) << sound('autodef.wav', 0)
                src.turretisauto = 1
                oview(12) << sound('turretfiring.wav', 0)
                src.dir = get_dir(src,M)
                if(istype(M,/mob/zombie))
                 var/damage = 10000
                 M.health -= damage
                 if(M.CheckDeath())
                  M.Death()
                  goto serp
            else
                src.icon_state = "attack"
                oview(12) << sound('turretfiring.wav', 0)
                src.dir = get_dir(src,M)
                if(istype(M,/mob/zombie))
                 var/damage = 10000
                 M.health -= damage
                 if(M.CheckDeath())
                  M.Death()
                  goto serp
        else
            return


Problem description: THe turret is supposed to shoot all the zombies in its oview(12) but they never even change icon_state so can someone help?

#1 Sep 11 2008, 5:23 pm
Three problems with this:
1) Never, ever, ever, ever, ever, ever, EVER use goto.
2) Use Boolean logic.
3) The last else return bit is unnescesary.
#2 Sep 11 2008, 5:35 pm
In response to Popisfizzy (#1)
why dont use goto? what should i use?
#3 Sep 11 2008, 5:45 pm
In response to SadoSoldier (#2)
A real loop such as for or while.

George Gough
#4 Sep 11 2008, 6:08 pm (Edited on Sep 11 2008, 6:44 pm)
In response to KodeNerd (#3)
Or recursion.
#5 Sep 11 2008, 7:02 pm
In response to Popisfizzy (#4)
Good point though I consider it a type of loop.

George Gough