TheLunarWolf's Site - HP Bug need help

ID:145481

Mar 8 2006, 2:56 pm

Code:

mob/verb
    attack(mob/M as mob in oview(1))     //attack a mob within 1 tile of you
        usr << "You attack [M]!"    //send this message to the usr
        oview() << "[usr] attacks [M]!" //send this message to everybody else
        var/damage = usr.str - M.def        //assign a random # to a new variable
        world << "[damage] damage!" //tell the damage to the world
        M.HP -= Damage()
        M.DeathCheck()
    Pickup()
    Equip ()
mob/verb
    Say(msg as text)            //what the usr says is passed into "msg" as text
        world << "[usr]: [msg]"     //the world sees chatroom-like output
    Stats ()
        usr << "Your Current HP is [usr.health]."
        usr << "Your strength is [usr.str]."
        usr << "Your defence is [usr.def]."
        usr << "Your mana is [usr.mana]."

Problem description:
loading kaefe.dme
kaefe.dm:63:error:M.HP:undefined var

kaefe.dmb - 1 error, 0 warnings (double-click on an error to jump to it)

I've the tutorials and several guides and I still don't understand the problem could someone please help with this

#1 Mar 8 2006, 2:58 pm

Mxjerrett

just add this

    var
        HP = 30

#2 Mar 8 2006, 3:49 pm

Worldweaver

Your also calling a Damage procedure

        var/damage = usr.str - M.def        //assign a random # to a new variable
        world << "[damage] damage!" //tell the damage to the world
        M.HP -= Damage()

You should be using the variable that you created: damage to subtact the HP

        var/damage = usr.str - M.def
        world << "[damage] damage!" 
        M.HP -= damage // - See the Variable?

#3 Mar 8 2006, 10:27 pm

In response to Worldweaver (#2)

Mega fart cannon

Well, he can do that, but his way is partly right. He can set a variable to a proc, as long as the proc returns a value.

mob
  proc/Damage() return 6

  verb/Check_Damage()
    var/D=Damage()
    usr<<"The Damage() proc returns [Damage()]"  //Outputs 6
    usr<<"The variable D returns [D]"  //Outputs 6

#4 Mar 9 2006, 2:20 am In response to Worldweaver (#2)
Jp	No put usr in proc.

#5 Mar 9 2006, 7:58 am In response to Jp (#4)
Mysame	Also, you need to pass the killer (usr) as an argument to your DeathCheck proc.

#6 Mar 9 2006, 8:02 am In response to Mysame (#5)
Crashed	src, you mean.

#7 Mar 9 2006, 8:24 am In response to Crashed (#6)
Mysame	Euh, in a verb you can easily pass usr INTO the DC, I mean. Not using the 'usr' in the proc.

#8 Mar 12 2006, 1:19 pm In response to Crashed (#6)
TheLunarWolf	Thanks I'll try these and report back if it works or not

#9 Mar 13 2006, 7:37 pm

Satans Spawn

TheLunarWolf wrote:

Code:

> mob/verb
>   attack(mob/M as mob in oview(1))     //attack a mob within 1 tile of you
>       usr << "You attack [M]!"    //send this message to the usr
>       oview() << "[usr] attacks [M]!" //send this message to everybody else
>       var/damage = usr.str - M.def        //assign a random # to a new variable
>       world << "[damage] damage!" //tell the damage to the world

>       >>M.HP<< -= Damage()

>       M.DeathCheck()
>   Pickup()
>   Equip ()
> mob/verb
>   Say(msg as text)            //what the usr says is passed into "msg" as text
>       world << "[usr]: [msg]"     //the world sees chatroom-like output
>   Stats ()

>       usr << "Your Current HP is [>>usr.health<<]."

>       usr << "Your strength is [usr.str]."
>       usr << "Your defence is [usr.def]."
>       usr << "Your mana is [usr.mana]."
>

All you really need to do, is ensure that your variables used remain constant. What I mean by this is, if you are using health as the variable to determine the life-force of the player/monster, you must use that variable everywhere they lose or gain life-force.

The two area's I have >>pointed<< to should have been noticed by the first poster, had (s)he read your code at all. But seeing as nobody noticed this, your code should look like this:

mob/verb
    attack(mob/M as mob in oview(1))     //attack a mob within 1 tile of you
        usr << "You attack [M]!"    //send this message to the usr
        oview() << "[usr] attacks [M]!" //send this message to everybody else
        var/damage = usr.str - M.def        //assign a random # to a new variable
        world << "[damage] damage!" //tell the damage to the world

        M.health -= Damage()

        M.DeathCheck()
    Pickup()
    Equip ()
mob/verb
    Say(msg as text)            //what the usr says is passed into "msg" as text
        world << "[usr]: [msg]"     //the world sees chatroom-like output
    Stats ()

        usr << "Your Current HP is [usr.health]."

        usr << "Your strength is [usr.str]."
        usr << "Your defence is [usr.def]."
        usr << "Your mana is [usr.mana]."

--§--