Simple code, doesn't return correctly in Developer Help

ID:142773
 
Mar 10 2008, 4:01 pm (Edited on Mar 10 2008, 4:12 pm)
Code:
mob/verb/scramble(t as text)
    if(!t||!istext(t))return t
    var/tt
    while(t)
        world<<"t=[t]"
        world<<"tt=[tt]"
        var/p=rand(1,length(t))
        tt+=copytext(t,p,p+1)
        t=addtext(copytext(t,1,p),copytext(t,p+1))
    return tt


Problem description:
Your supposed to input text, and it scrambles the text.
so i input "!!!!" i'd doesn't matter how much you scramble !!!! it will always end up as !!!!, but of course this code is returning !! or !!! or !.
#1 Mar 10 2008, 4:43 pm
Alternative:

mob/verb/Scramble(text as text)
    src << "[text] --> [scrambletext(text)]"


// Rearranges the letters in a line of text.
proc/scrambletext(text)
    if(!text || !istext(text))
        return text
        
    var/list/letters = list()
    var/t = copytext(text, 1, 2)
    
    while(t)
        letters += t
        text = copytext(text, 2, 0)
        t = copytext(text, 1, 2)
        
    var/result = ""
    while(letters.len)
        var/letter = pick(letters)
        letters -= letter
        result += letter
        
    return result
#2 Mar 10 2008, 5:11 pm
In response to Foomer (#1)
No! list! If any of the letters repeat(more than likely) it only displays them once >_>.
#3 Mar 10 2008, 5:37 pm
In response to Tubutas (#2)
Tubutas wrote:
No! list! If any of the letters repeat(more than likely) it only displays them once >_>.

That's only for associated lists.
#4 Mar 10 2008, 5:38 pm
In response to Foomer (#3)
oh?... why is that?