Click() problem in Developer Help

ID:140324
 
Feb 17 2010, 8:57 am (Edited on Feb 17 2010, 9:16 am)
Code:
client/New()//When a client connects to a mob
    ..()
    new/obj/hud/button1(src)


obj
    hud
        var
            clicked
            
        clicked = 0

        button1
            layer = MOB_LAYER + 2
            icon = 'button1.dmi'
            icon_state = "1"
            New(client/C)
                screen_loc = "1,1"
                C.screen+=src
            DblClick()
                if(src.clicked == 0)
                    src.icon_state = "2"
                    src.clicked = 1
                if(src.clicked == 1)
                    src.icon_state = "1"
                    src.clicked = 0


Problem description:
dont work

Edit
        button1
            layer = MOB_LAYER + 2
            icon = 'button1.dmi'
            icon_state = "1"
            New(client/C)
                screen_loc = "1,1"
                C.screen+=src
            DblClick()
                if(src.clicked == 0)
                    src.icon_state = "2"
                    src.clicked = 1
                    return
                if(src.clicked == 1)
                    src.icon_state = "1"
                    src.clicked = 0
                    return
#1 Feb 17 2010, 9:09 am
 
            DblClick()
                if(src.clicked == 0)
                    src.icon_state = "2"
                    src.clicked = 1
                if(src.clicked == 1)
                    src.icon_state = "1"
                    src.clicked = 0


Replace src with usr.

To add as a learning experience, you CAN use usr in Click() if that's what you were thinking.
#2 Feb 17 2010, 9:09 am
In response to Gr1m d4 r34p3r (#1)
Euhh. Nooooo.
#3 Feb 17 2010, 9:10 am
In response to Gr1m d4 r34p3r (#1)
No, don't, src is the object being clicked, usr the the object clicking.
#4 Feb 17 2010, 9:11 am
In response to Ulterior Motives (#3)
He wants the usr to change, right?
#5 Feb 17 2010, 9:13 am
In response to Gr1m d4 r34p3r (#4)
He is changing a variable named clicked that belongs to the object being clicked. So I would assume not. Since he doesn't state what doesn't work that makes it a little harder to find out what he is trying to do.
#6 Feb 17 2010, 9:14 am
In response to Gr1m d4 r34p3r (#4)
nvm i found out the problem, add return after src.clicked = 0 and src.clicked = 1
#7 Feb 17 2010, 9:21 am
In response to Ulterior Motives (#5)
the problem was that it set the "clicked" to 1 then went to the next command which turned "clicked" to 0. kinda confusing since this never happened before to me.
#8 Feb 17 2010, 9:26 am
In response to XnathanielX (#7)
 
            DblClick()
                if(!src.clicked)
                    src.icon_state = "2"
                    src.clicked = TRUE
                else if(src.clicked)
                    src.icon_state = "1"
                    src.clicked = FALSE

Since you are using two if() statements like that it is checking if clicked is 0. Then changing it to 1 and continuing on to the next if() statement. Using an else or else if() statement should solve that.
#9 Feb 17 2010, 9:39 am
In response to Ulterior Motives (#8)
ah never knew you could put else and if together.
#10 Feb 17 2010, 10:31 am
In response to Ulterior Motives (#8)
Or, you could shorten all the useless if-else evaluation and simply operate on what you need ;)

DblClick()
    clicked = !clicked
    icon_state = "[clicked]"


Granted, you'd have to rename the icon states from 1/2, to 0/1, but, well... if you really like them as 1/2, just replace "[clicked]" by "[clicked + 1]".
#11 Feb 17 2010, 5:18 pm
In response to XnathanielX (#9)
"else if" is just shorthand. These two are equivalent:
if(A)
  //A
else
  if(B)
    //B
  else
    if(C)
      //C
    else
      //D


if(A)
  //A
else if(B)
  //B
else if(C)
  //C
else
  //D
#12 Feb 18 2010, 1:21 am (Edited on Feb 18 2010, 1:27 am)
In response to Schnitzelnagler (#10)
Never thought of doing that. When I first looked at it, it seemed it should make clicked = 0. After I thought about it though, it made sense because of the ! operator. The more you know.