Reusing a variable name in the same scope of a proc doesn't properly error, but ONLY if the first variable is set to something related to another, global variable
Numbered Steps to Reproduce Problem:
Create a global variable
Create a new proc
Set a new variable to the global var
Set another new var of the same name to some value
Code Snippet (if applicable) to Reproduce Problem:
// Silences unused errors, unrelated to bug
/proc/silence()
return
var/global/atom/jerry
/proc/test()
var/testing = jerry
silence(testing)
var/testing = list()
silence(testing)
Expected Results:
An error
Actual Results:
Silently continues on, introducing var shadowing in the same scope
Does the problem occur:
Every time? Or how often? Every time
In other games? N/A
In other user accounts? Yes
On other computers? Yes
When does the problem NOT occur?
If the first var isn't a global. If the second doesn't get a specified value we get other errors about expecting a =
Did the problem NOT occur in any earlier versions? If so, what was the last version that worked? (Visit http://www.byond.com/download/build to download old versions for testing.)
Errors as expected on 1585, breaks on 1586
Workarounds:
N/A
Resolved over on https://www.byond.com/forum/post/2846816