ID:2890113
 
Resolved
Double-clicking in the output pane after a Find All when the line in the source code was very long could cause a crash.
BYOND Version:514
Operating System:Windows 10 Home 64-bit
Web Browser:Firefox 117.0
Applies to:Dream Maker
Status: Resolved (515.1620)

This issue has been resolved.
Descriptive Problem Summary:

Numbered Steps to Reproduce Problem:
1. Paste the snippet into a file.
2. Paste the snippet into find & "Find all".
3. Click on the match in the output window.
Code Snippet (if applicable) to Reproduce Problem:
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa


Expected Results:
Dream Maker jumps to the line in the code.

Actual Results:
Dream Maker crashes.

Does the problem occur:
Every time? Or how often?
Yes.
In other games?
N/A
In other user accounts?
N/A
On other computers?
Untested.

When does the problem NOT occur?
I haven't tested the exact amount. But it seems that the crash only occurs if there are roughly more than one thousand characters on a single line.
Did the problem NOT occur in any earlier versions? If so, what was the last version that worked? (Visit http://www.byond.com/download/build to download old versions for testing.)
Untested.
Workarounds:
Space out lines.
I've tried to reproduce this on 515.1618 but nothing is showing up. Can you confirm this has been fixed?
Lummox JR changed status to 'Unverified'
Crash still seems to happen for me on 515.1619

Video example of the crash on the latest beta:
https://imgur.com/a/PRXLQsM
I think the disconnect here is that your code snippet alone is definitely not enough to reproduce this problem. Note that in your video you have other lines in your file. Also your numbered steps to reproduce the problem mentioned nothing about searching through included files rather than just the current file, which is obviously relevant to any find/replace action. So there's just a lot of missing information here.

I'll need a test project from you to reproduce this.
Sorry, the video was rather rushed and poor on my part. It would've been better to include more information alongside it.

1. Find in files isn't needed and was a mistake on my part. Clicking matches in the output window from any "Find all" will cause the crash.

2. As for the snippet itself, I can directly copy paste it (As I've been doing) and search for it in dream maker to cause the crash. Here's it on an external site in case it's (unlikely) getting trimmed here. https://pastebin.com/bE24nbeP (Scratch that, it seems it was removed for being spam. I'll just send you a test project via discord.)

3. The line count doesn't seem to matter, I'm able to reproduce it with a otherwise empty file that only contains the long line.
Lummox JR resolved issue with message:
Double-clicking in the output pane after a Find All when the line in the source code was very long could cause a crash.