ID:2914419
 
Resolved
browse_rsc() was failing to write extracted icon files properly.
BYOND Version:515.1631
Operating System:Windows 10 Pro 64-bit
Web Browser:Firefox 112.0
Applies to:Dream Seeker
Status: Resolved (515.1632)

This issue has been resolved.
Descriptive Problem Summary:
It seems that in 515.1631 browse_rsc no longer works with /icon, which makes file in client's cache without icon data (image itself)

Numbered Steps to Reproduce Problem:
1. Have a .dmi file
2. Make an /icon using icon()
3. Send it to client using browse_rsc
4. Take a look into "cache/tmp..." folder
5. You'll see that file appeared, but it's size is 0 bytes.
Code Snippet (if applicable) to Reproduce Problem:
/client/New()
. = ..()
var/icon/icon = icon('example.dmi', icon_state = "example")
src << browse_rsc(icon, "example.png")


Expected Results:
"example.png" would contain actual image
Actual Results:
"example.png" is an empty file
Does the problem occur:
Every time? Or how often?
Always
In other games?
SS13 at least, tested in a specifically made project for reproducing this problem.
In other user accounts?
Yes
On other computers?
Not sure, tested only on Windows 10

IMPORTANT UPDATE:
I tried sending icon image from 515.1631 server to 515.1630 client and it works fine.
Sending from 515.1631 server to 515.1631 client resulted in a no image data.
Sending from 515.1630 server to 515.1631 client resulted in a no image data.
It looks like Dream Seeker's issue of not-accepting icon data

When does the problem NOT occur?
Problem does not occur when tested on previous versions (515.1630 and lower)
Did the problem NOT occur in any earlier versions? If so, what was the last version that worked? (Visit http://www.byond.com/download/build to download old versions for testing.)
Problem is not presented in versions lower than 515.1631 (515.1630 and lower)
Workarounds:
Workaround is to encode icon to base64 and embed it into browser with "data:image/png;base64" instruction.
Lummox JR resolved issue with message:
browse_rsc() was failing to write extracted icon files properly.