Garthor Please Help

ID:263633
 
Jun 22 2007, 4:28 pm (Edited on Jun 22 2007, 4:41 pm)
Code:
mob
    proc
        LvlCheck()
            if(usr.Exp>=usr.Mexp)
                usr<<"<I><b><font size = 1><font color = white>Congratulations,You have leveled up!!"
                usr.level+=1
                usr.MHP+=rand(10,25)
                usr.HP=usr.MHP
                usr.MPP+=rand(1,2)
                usr.PP=usr.MPP
                usr.Mstr+=rand(5,10)
                usr.Str=usr.Mstr
                usr.Mdef+=rand(1,2)
                usr.Def=usr.Mdef
                usr.Expg*=1
                usr.Exp=0
                usr.Evolve()
                usr.Evolve2()

            if(usr.level >= 5 && usr.Type == "Fire" && usr.learn_ember == 0)
                usr << "<b><font size = 1><font color = white>You learnt Ember!!"
                usr.learn_ember = 1
                usr.verbs+=new/mob/tech/verb/Ember
            else
                if(usr.learn_ember == 1)
                    return

            if(usr.level >= 20 && usr.Type == "Fire" && src.learn_FlameThrower == 0)
                usr << "<b><font size = 1><font color = white>You learnt FlameThrower!!"
                src.learn_FlameThrower = 1
                usr.verbs+=new/mob/tech/verb/Flame_Thrower
            else
                if(src.learn_FlameThrower == 1)
                    return

            if(usr.level >= 5 && usr.Type == "Water" && src.learn_bubble == 0)
                usr << "<b><font size = 1><font color = white>You learnt Bubble!!"
                src.learn_bubble = 1
                usr.verbs+=new/mob/tech/verb/Bubble
            else
                if(src.learn_bubble == 1)
                    return

            if(usr.level >= 20 && usr.Type == "Water" && src.learn_Bubble_Gun == 0)
                usr << "<b><font size = 1><font color = white>You learnt Bubble Gun!!"
                src.learn_Bubble_Gun = 1
                usr.verbs+=new/mob/tech/verb/Bubble_Gun
            else
                if(src.learn_Bubble_Gun == 1)
                    return

            if(usr.level >= 5 && usr.Type == "Grass" && src.learn_bullet_seed == 0)
                usr << "<b><font size = 1><font color = white>You learnt Bullet Seed!!"
                src.learn_bullet_seed = 1
                usr.verbs+=new/mob/tech/verb/Bullet_Seed()
            else
                if(src.learn_bullet_seed == 1)
                    return

            if(usr.level >= 20 && usr.Type == "Grass" && src.learn_Vine_Whip == 0)
                usr << "<b><font size = 1><font color = white>You learnt Vine Whip!!"
                src.learn_Vine_Whip = 1
                usr.verbs+=new/mob/tech/verb/Vine_Whip()
            else
                if(src.learn_Vine_Whip == 1)
                    return

            if(usr.level >= 5 && usr.Type == "Thunder" && src.learn_thunder == 0)
                usr << "<b><font size = 1><font color = white>You learnt Thunder!!"
                src.learn_thunder = 1
                usr.verbs+=new/mob/tech/verb/Thunder()
            else
                if(src.learn_thunder == 1)
                    return

            if(usr.level >= 20 && usr.Type == "Thunder" && src.learn_Thunderbolt == 0)
                usr << "<b><font size = 1><font color = white>You learnt Thunder Bolt!!"
                src.learn_Thunderbolt = 1
                usr.verbs+=new/mob/tech/verb/Thunder_Bolt()
            else
                if(src.learn_Thunderbolt == 1)
                    return

            if(usr.level >= 5 && usr.Type == "Rock" && src.learn_rock == 0)
                usr << "<b><font size = 1><font color = white>You learnt Rock Throw!!"
                src.learn_rock = 1
                usr.verbs+=new/mob/tech/verb/Rock_Throw()
            else
                if(src.learn_rock == 1)
                    return


            if(usr.level >= 20 && usr.Type == "Normal" && src.learn_Bite == 0)
                usr << "<b><font size = 1><font color = white>You learnt Bite!!"
                src.learn_Bite = 1
                usr.verbs+=new/mob/tech/verb/Bite()
            else
                if(src.learn_Bite == 1)
                    return

            if(usr.level >= 20 && usr.Type == "Normal" && src.learn_Psycic == 0)
                usr << "<b><font size = 1><font color = white>You learnt Psycic!!"
                src.learn_Psycic = 1
                usr.verbs+=new/mob/tech/verb/Psycic()
            else
                if(src.learn_Psycic == 1)
                    return

            if(usr.level >= 5 && usr.Type == "Ghost" && src.learn_ghost == 0)
                usr << "<b><font size = 1><font color = white>You learnt Ghost Form!!"
                src.learn_ghost = 1
                usr.verbs+=new/mob/tech/verb/Ghost_Form()
            else
                if(src.learn_ghost == 1)
                    return

            if(usr.level >= 20 && usr.Type == "Ghost" && src.learn_Scary_Face == 0)
                usr << "<b><font size = 1><font color = white>You learnt Scary Face!!"
                src.learn_Scary_Face = 1
                usr.verbs+=new/mob/tech/verb/Scary_Face()
            else
                if(src.learn_Scary_Face == 1)
                    return

            if(usr.level >= 5 && usr.Type == "Flying" && src.learn_whirl == 0)
                usr << "<b><font size = 1><font color = white>You learnt Whirlwind!!"
                src.learn_whirl = 1
                usr.verbs+=new/mob/tech/verb/Whirlwind()
            else
                if(src.learn_whirl == 1)
                    return

            if(usr.level >= 5 && usr.Type == "Dragon" && src.learn_twister == 0)
                usr << "<b><font size = 1><font color = white>You learnt Twister!!"
                src.learn_twister = 1
                usr.verbs+=new/mob/tech/verb/Twister()
            else
                if(src.learn_twister == 1)
                    return


Problem description:It doesnt give me the skills,it doesnt even say that I learned it even if Im the right type and I got the same or higher lv it requires,how do you fix this?Please Help.

Jun 22 2007, 4:30 pm
Because you're returning (which ends the proc) before that happens.

Also: Holy mother of crap, DO NOT USE USR IN PROCS.

I mean... DAMN. Every single ONE of those should be src.
Jun 22 2007, 4:34 pm (Edited on Jun 22 2007, 4:44 pm)
In response to Garthor
Im just changed it to usr like 2 min ago bcuz it wasnt working with src..and 2nd if I dont put return it will keep saying "you have learnt (Skill Name) !!"over and over again.can you show me how the fixed code should look please?
Jun 22 2007, 4:52 pm
In response to Element Hero creator
Element Hero creator wrote:
Im just changed it to usr like 2 min ago bcuz it wasnt working with src..

"My car wouldn't start so I smashed the windshield with a sledgehammer."

and 2nd if I dont put return it will keep saying "you have learnt (Skill Name) !!"over and over again.

No, it won't.

can you show me how the fixed code should look please?

Yes, but I won't.
Jun 22 2007, 6:06 pm
In response to Garthor
Garthor wrote:
"My car wouldn't start so I smashed the windshield with a sledgehammer."

That is such an exaggeration.

Jun 22 2007, 6:29 pm
In response to Revenant Jesus
Revenant Jesus wrote:
Garthor wrote:
"My car wouldn't start so I smashed the windshield with a sledgehammer."

That is such an exaggeration.



Yeah but it's funny :)
Jun 23 2007, 5:41 am
In response to Revenant Jesus
Revenant Jesus wrote:
Garthor wrote:
"My car wouldn't start so I smashed the windshield with a sledgehammer."

That is such an exaggeration.

Not so much. Randomly replacing src with usr because the code isn't working as expected is not a bright thing to do. The same mindset tosses usr into code like Entered(). Putting usr in a proc can't fix your problems, since it automatically creates a brand new one.

If you smash the windshield, the car still won't start, and now it's got no windshield and broken glass all over the seats. That's actually a pretty brilliant analogy.

Lummox JR
Jun 23 2007, 7:52 am
Element Hero creator wrote:
Code:
mob
>   proc
>       LvlCheck()
>           if(usr.Exp>=usr.Mexp)
>               usr<<"<I><b><font size = 1><font color = white>Congratulations,You have leveled up!!"
>               usr.level+=1
>               usr.MHP+=rand(10,25)
>               usr.HP=usr.MHP
>               usr.MPP+=rand(1,2)
>               usr.PP=usr.MPP
>               usr.Mstr+=rand(5,10)
>               usr.Str=usr.Mstr
>               usr.Mdef+=rand(1,2)
>               usr.Def=usr.Mdef
>               usr.Expg*=1
>               usr.Exp=0
>               usr.Evolve()
>               usr.Evolve2()
> 
>           if(usr.level >= 5 && usr.Type == "Fire" && usr.learn_ember == 0)
>               usr << "<b><font size = 1><font color = white>You learnt Ember!!"
>               usr.learn_ember = 1
>               usr.verbs+=new/mob/tech/verb/Ember
>           else
>               if(usr.learn_ember == 1)
>                   return
> 
>           if(usr.level >= 20 && usr.Type == "Fire" && src.learn_FlameThrower == 0)
>               usr << "<b><font size = 1><font color = white>You learnt FlameThrower!!"
>               src.learn_FlameThrower = 1
>               usr.verbs+=new/mob/tech/verb/Flame_Thrower
>           else
>               if(src.learn_FlameThrower == 1)
>                   return
> 
>           if(usr.level >= 5 && usr.Type == "Water" && src.learn_bubble == 0)
>               usr << "<b><font size = 1><font color = white>You learnt Bubble!!"
>               src.learn_bubble = 1
>               usr.verbs+=new/mob/tech/verb/Bubble
>           else
>               if(src.learn_bubble == 1)
>                   return
> 
>           if(usr.level >= 20 && usr.Type == "Water" && src.learn_Bubble_Gun == 0)
>               usr << "<b><font size = 1><font color = white>You learnt Bubble Gun!!"
>               src.learn_Bubble_Gun = 1
>               usr.verbs+=new/mob/tech/verb/Bubble_Gun
>           else
>               if(src.learn_Bubble_Gun == 1)
>                   return
> 
>           if(usr.level >= 5 && usr.Type == "Grass" && src.learn_bullet_seed == 0)
>               usr << "<b><font size = 1><font color = white>You learnt Bullet Seed!!"
>               src.learn_bullet_seed = 1
>               usr.verbs+=new/mob/tech/verb/Bullet_Seed()
>           else
>               if(src.learn_bullet_seed == 1)
>                   return
> 
>           if(usr.level >= 20 && usr.Type == "Grass" && src.learn_Vine_Whip == 0)
>               usr << "<b><font size = 1><font color = white>You learnt Vine Whip!!"
>               src.learn_Vine_Whip = 1
>               usr.verbs+=new/mob/tech/verb/Vine_Whip()
>           else
>               if(src.learn_Vine_Whip == 1)
>                   return
> 
>           if(usr.level >= 5 && usr.Type == "Thunder" && src.learn_thunder == 0)
>               usr << "<b><font size = 1><font color = white>You learnt Thunder!!"
>               src.learn_thunder = 1
>               usr.verbs+=new/mob/tech/verb/Thunder()
>           else
>               if(src.learn_thunder == 1)
>                   return
> 
>           if(usr.level >= 20 && usr.Type == "Thunder" && src.learn_Thunderbolt == 0)
>               usr << "<b><font size = 1><font color = white>You learnt Thunder Bolt!!"
>               src.learn_Thunderbolt = 1
>               usr.verbs+=new/mob/tech/verb/Thunder_Bolt()
>           else
>               if(src.learn_Thunderbolt == 1)
>                   return
> 
>           if(usr.level >= 5 && usr.Type == "Rock" && src.learn_rock == 0)
>               usr << "<b><font size = 1><font color = white>You learnt Rock Throw!!"
>               src.learn_rock = 1
>               usr.verbs+=new/mob/tech/verb/Rock_Throw()
>           else
>               if(src.learn_rock == 1)
>                   return
> 
> 
>           if(usr.level >= 20 && usr.Type == "Normal" && src.learn_Bite == 0)
>               usr << "<b><font size = 1><font color = white>You learnt Bite!!"
>               src.learn_Bite = 1
>               usr.verbs+=new/mob/tech/verb/Bite()
>           else
>               if(src.learn_Bite == 1)
>                   return
> 
>           if(usr.level >= 20 && usr.Type == "Normal" && src.learn_Psycic == 0)
>               usr << "<b><font size = 1><font color = white>You learnt Psycic!!"
>               src.learn_Psycic = 1
>               usr.verbs+=new/mob/tech/verb/Psycic()
>           else
>               if(src.learn_Psycic == 1)
>                   return
> 
>           if(usr.level >= 5 && usr.Type == "Ghost" && src.learn_ghost == 0)
>               usr << "<b><font size = 1><font color = white>You learnt Ghost Form!!"
>               src.learn_ghost = 1
>               usr.verbs+=new/mob/tech/verb/Ghost_Form()
>           else
>               if(src.learn_ghost == 1)
>                   return
> 
>           if(usr.level >= 20 && usr.Type == "Ghost" && src.learn_Scary_Face == 0)
>               usr << "<b><font size = 1><font color = white>You learnt Scary Face!!"
>               src.learn_Scary_Face = 1
>               usr.verbs+=new/mob/tech/verb/Scary_Face()
>           else
>               if(src.learn_Scary_Face == 1)
>                   return
> 
>           if(usr.level >= 5 && usr.Type == "Flying" && src.learn_whirl == 0)
>               usr << "<b><font size = 1><font color = white>You learnt Whirlwind!!"
>               src.learn_whirl = 1
>               usr.verbs+=new/mob/tech/verb/Whirlwind()
>           else
>               if(src.learn_whirl == 1)
>                   return
> 
>           if(usr.level >= 5 && usr.Type == "Dragon" && src.learn_twister == 0)
>               usr << "<b><font size = 1><font color = white>You learnt Twister!!"
>               src.learn_twister = 1
>               usr.verbs+=new/mob/tech/verb/Twister()
>           else
>               if(src.learn_twister == 1)
>                   return
>

Problem description:It doesnt give me the skills,it doesnt even say that I learned it even if Im the right type and I got the same or higher lv it requires,how do you fix this?Please Help.


i suppose since nobody else will help you, i'll be nice for once :P.

mob
    var
        learned=list()//makes a "learned" var, this is a list.
    proc
        LvlCheck()
            if(Exp>=Mexp)//first problem, usr does NOT belong in a proc, use src..as a matter of fact, since src is the "default" in procs, you dont even need to define it
                src<<"<I><b><font size = 1><font color = white>Congratulations,You have leveled up!!"
                level++//check out boolean variables
                MHP+=rand(10,25)
                HP=usr.MHP
                MPP+=rand(1,2)
                PP=usr.MPP
                Mstr+=rand(5,10)
                Str=usr.Mstr
                Mdef+=rand(1,2)
                Def=usr.Mdef
                Expg*=1
                Exp=0
                Evolve()
                Evolve2()
                if(type=="Fire")
                    if(level>=5&&!("Ember" in learned))//if src's level is greater or equal to 5 and the text string "Ember" is not in src's learned var
                        src << "<b><font size = 1><font color = white>You learnt Ember!!</font>"
                        learned+="Ember"//adds the text string "Ember" to src's learned var
                        verbs+=new/mob/tech/verb/Ember


now of course, you have to finish the code, i'm not >_>'