Missing comma ',' or right-paren ')'

ID:146013
 
Oct 8 2005, 9:52 am
Code:
switch(input("What race do you want to be?","Character Creation") in list("Temprion","Morkron","Finity","Krasj")
    if ("Temprion")
    character = new /mob/characters/Temprion()
switch(input("What gender?","Character Creation") in list("Male","Female")
    if("Male")
        icon_state="TempMale"
    else
        icon_state="TempFemale"
    if ("Morkron")
    character = new /mob/characters/Morkron()
switch(input("What gender?","Character Creation") in list("Male","Female")
    if("Male")
        icon_state="MorMale"
    else
        icon_state="MorFemale"
    if ("Finity")
    character = new /mob/characters/Finity()
switch(input("What gender?","Character Creation") in list("Male","Female")
    if("Male")
        icon_state="FinMale"
    else
        icon_state="FinFemale"
    if ("Krasj")
    character = new /mob/characters/Krasj()
        icon_state="Krasj"


Problem description: Missing comma ',' or right-paren ')' ... What the hell did I do wrong this time?!
PS: says the problem is at if("Temprion")

Oct 8 2005, 9:55 am
Add another ) to the switches. You are leaving it open.
Oct 8 2005, 9:57 am
In response to Soccerguy13
Thanks, so I did!

Now dreammaker detects another problem, wich I knew it would; in this line:

            var/damage = usr.str *= 2 -= M.defense


Kinda forgot how you multiply... -.-
Oct 8 2005, 10:00 am
In response to Mysame
 
var/damage = (usr.str *2) - M.defense


You don't have to use the ()'s but I always do. It will follow the correct order of operations without them, but I just prefer it that way.
Oct 8 2005, 10:15 am
In response to Soccerguy13
Thanks again, but holy **** , I fixed that and now everything else has gone boom! 151 errors, ka-tching!
Lemme just c/p the whole code...

world
    mob = /mob/create_character
    turf = /turf/grass
    view = 9

mob/create_character
    var/mob/character
        Login()

        var/charactername = input("Welcome! What is your name?","Character Creation")
        
        switch(input("Choose your Alignment.","Character Creation","Neutral") in list("Heavenly","Neutral","Chaotic"))
            if("Heavenly")
                usr.alignment = "Heavenly"
            if("Neutral")
                usr.alignment = "Neutral"
            if("Chaotic")
                usr.alignment = "Chaotic"

switch(input("What race do you want to be?","Character Creation") in list("Temprion","Morkron","Finity","Krasj"))
    if ("Temprion")
    character = new /mob/characters/Temprion()
switch(input("What gender?","Character Creation") in list("Male","Female"))
    if("Male")
        icon_state="TempMale"
    else
        icon_state="TempFemale"
    if ("Morkron")
    character = new /mob/characters/Morkron()
switch(input("What gender?","Character Creation") in list("Male","Female"))
    if("Male")
        icon_state="MorMale"
    else
        icon_state="MorFemale"
    if ("Finity")
    character = new /mob/characters/Finity()
switch(input("What gender?","Character Creation") in list("Male","Female"))
    if("Male")
        icon_state="FinMale"
    else
        icon_state="FinFemale"
    if ("Krasj")
    character = new /mob/characters/Krasj()
        icon_state="Krasj"

        character.name = charactername
        src.client.mob = character
        del(src)
        ..()

mob/characters/Temprion
    str=15
    HP = 50
    maxHP = 50
    defense = 3
    gold = 0
    exp = 0
    maxexp = 40
    Level = 1
    mana = 2
    maxmana = 2
    energy = 100

mob/characters/Morkron
    str=4
    HP = 40
    maxHP = 40
    defense = 7
    gold = 0
    exp = 0
    maxexp = 40
    Level = 1
    mana = 30
    maxmana = 30
    energy = 100

mob/characters/Finity
    str=7
    HP = 45
    maxHP = 45
    defense = 5
    gold = 50
    exp = 0
    maxexp = 40
    Level = 1
    mana = 15
    maxmana = 15
    energy = 100

mob/characters/Krasj
    str=12
    HP = 5
    maxHP = 5
    defense = 12
    gold = 0
    exp = 0
    maxexp = 40
    Level = 1
    mana = 1
    maxmana = 1
    energy = 100

mob
    proc
        Character_Login()
            world <<"_-_[usr] Logs In_-_"
    verb
        Say(mesg as text)
            world << "[usr] says: [mesg]"
    verb
        Attack(mob/M)
            statpanel("Skills")
            var/damage = usr.str - (M.defense / 1.5)
            if(dmg>=0)
                usr<<"[M] dodges the attack!"
            else
                M.hp -= damage
            if(M.hp<=0)
                usr.kills += 1
                view()<<"[usr] attacks [M] for [damage] HP!"
                M:Deathcheck()
    proc
        Deathcheck()
            if(src.hp<=0)
                view()<<"[src] dies!"
                src.deaths += 1
                src.move (locate(1,1,1))

mob
    var
        armor_equipped = 0
        weapon_equipped = 0
    Stat()
        statpanel("Stats")
        stat("Level",usr.level)
        stat("Experience",usr.exp / usr.maxexp)
        stat("HP",usr.hp / usr.maxhp)
        stat("Strength",usr.str)
        stat("Defense",usr.defense)
        stat("Energy",usr.energy)
        stat("------------------------")
        stat("Gold",usr.gold)
        stat("Kills",usr.kills)
        stat("Deaths",usr.deaths)


Anyone keen enough to find ALL 151? You get a cookie if you do!

Oct 8 2005, 10:24 am
In response to Mysame
 
mob
    create_character
        var/mob/character
        Login()
            var/charactername = input("Welcome! What is your name?","Character Creation")   
            switch(input("Choose your Alignment.","Character Creation","Neutral") in list("Heavenly","Neutral","Chaotic"))
                if("Heavenly")
                    usr.alignment = "Heavenly"
                if("Neutral")
                    usr.alignment = "Neutral"
                if("Chaotic")
                    usr.alignment = "Chaotic"
            switch(input("What race do you want to be?","Character Creation") in list("Temprion","Morkron","Finity","Krasj"))
                if ("Temprion")
                    character = new /mob/characters/Temprion()
                    switch(input("What gender?","Character Creation") in list("Male","Female"))
                        if("Male")
                            icon_state="TempMale"
                        else
                            icon_state="TempFemale"
                if ("Morkron")
                    character = new /mob/characters/Morkron()
                    switch(input("What gender?","Character Creation") in list("Male","Female"))
                        if("Male")
                            icon_state="MorMale"
                        else
                            icon_state="MorFemale"
                if ("Finity")
                    character = new /mob/characters/Finity()
                    switch(input("What gender?","Character Creation") in list("Male","Female"))
                        if("Male")
                            icon_state="FinMale"
                        else
                            icon_state="FinFemale"
                if ("Krasj")
                    character = new /mob/characters/Krasj()
                    icon_state="Krasj"
                character.name = charactername
                src.client.mob = character
                del(src)
                ..()

Your indentation was off.
Oct 8 2005, 10:31 am
In response to Soccerguy13
Thanks, but now it says EVERYTHING is an unidentified var...?
Oct 8 2005, 10:36 am
In response to Mysame
 
    create_character
        var/mob/character
        Login()
            var/charactername = input("Welcome! What is your name?","Character Creation")   
            switch(input("Choose your Alignment.","Character Creation","Neutral") in list("Heavenly","Neutral","Chaotic"))
                if("Heavenly")
                    src.alignment = "Heavenly"
                if("Neutral")
                    src.alignment = "Neutral"
                if("Chaotic")
                    src.alignment = "Chaotic"
            switch(input("What race do you want to be?","Character Creation") in list("Temprion","Morkron","Finity","Krasj"))
                if ("Temprion")
                    character = new /mob/characters/Temprion()
                    switch(input("What gender?","Character Creation") in list("Male","Female"))
                        if("Male")
                            icon_state="TempMale"
                        else
                            icon_state="TempFemale"
                if ("Morkron")
                    character = new /mob/characters/Morkron()
                    switch(input("What gender?","Character Creation") in list("Male","Female"))
                        if("Male")
                            icon_state="MorMale"
                        else
                            icon_state="MorFemale"
                if ("Finity")
                    character = new /mob/characters/Finity()
                    switch(input("What gender?","Character Creation") in list("Male","Female"))
                        if("Male")
                            icon_state="FinMale"
                        else
                            icon_state="FinFemale"
                if ("Krasj")
                    character = new /mob/characters/Krasj()
                    icon_state="Krasj"
            character.name = charactername
            src.client.mob = character
            del(src)
            ..()

Sorry, I had some bad indentation and other problems in there. This should work. I added the variables in for me in a project and I got no errors.
Oct 8 2005, 10:45 am
In response to Soccerguy13
Well, it says the HP, defense, gold, etc... are uniditified vars... Not in that piece of coding, but in the stats and all :|..
Real frustrating

G'night, and thanks again!
Oct 8 2005, 10:58 am
In response to Mysame
You might want to look at your capitalization. Variables are case-sensitive, and it looks to me you might have some wrong.
Oct 8 2005, 11:05 am
In response to Mysame
Make sure it you have all your caps right. Variables are case-sensitive. Also, make sure all your variables are defined.
mob
     var
          HP
          Gold//etc